Skip to content

HBASE-28184 Tailing the WAL is very slow if there are multiple peers #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahrs87 merged 5 commits into from
Nov 7, 2023
Merged

HBASE-28184 Tailing the WAL is very slow if there are multiple peers #5503

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c701f4
HBASE-28184 Tailing the WAL is very slow if there are multiple peers
shahrs87 Nov 3, 2023
db7f754
HBASE-28184 Tailing the WAL is very slow if there are multiple peers
shahrs87 Nov 3, 2023
ad00506
HBASE-28184 Review comments
shahrs87 Nov 4, 2023
2ca7a58
Merge branch 'master' of https://github.com/apache/hbase into HBASE-2…
shahrs87 Nov 6, 2023
6f2ef86
Addressing review comments
shahrs87 Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,12 @@ private Pair<WALTailingReader.State, Boolean> readNextEntryAndRecordReaderPositi
// in the future, if we want to optimize the logic here, for example, do not call this method
// every time, or do not acquire rollWriteLock in the implementation of this method, we need to
// carefully review the optimized implementation

@virajjasani virajjasani Nov 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: now that we have comments for both if and else, maybe good to remove from here?

OptionalLong fileLength = walFileLengthProvider.getLogFileSizeIfBeingWritten(currentPath);
OptionalLong fileLength = OptionalLong.empty();
if (logQueue.getQueueSize(walGroupId) == 1) {
// Get the size of log file only if there is 1 log file in the queue. If there are
// more than 1 log file in the queue, then the head will never be the current WAL file.
fileLength = walFileLengthProvider.getLogFileSizeIfBeingWritten(currentPath);
}
WALTailingReader.Result readResult = reader.next(fileLength.orElse(-1));
long readerPos = readResult.getEntryEndPos();
Entry readEntry = readResult.getEntry();
Expand Down