Skip to content

HBASE-28153 Upgrade zookeeper to a newer version (#5484) #5490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Apache9 merged 1 commit into from
Nov 2, 2023
Merged

HBASE-28153 Upgrade zookeeper to a newer version (#5484) #5490

Apache9 merged 1 commit into from
Nov 2, 2023

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Nov 1, 2023

Backport of #5475

(cherry picked from commit 0d04a60)

@Apache9 Apache9 self-assigned this Nov 1, 2023
@Apache-HBase
Copy link

Apache-HBase commented Nov 1, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 2m 20s branch-2.4 passed
+1 💚 compile 4m 27s branch-2.4 passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for patch
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 4m 28s the patch passed
+1 💚 javac 4m 28s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 16m 40s Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
35m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5490
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux e11bb6eeaa47 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 57fea96
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-zookeeper hbase-server hbase-it . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 1, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 48s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 2m 25s branch-2.4 passed
+1 💚 compile 1m 39s branch-2.4 passed
+1 💚 shadedjars 4m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 42s branch-2.4 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 2m 16s the patch passed
+1 💚 compile 1m 41s the patch passed
+1 💚 javac 1m 41s the patch passed
+1 💚 shadedjars 4m 20s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 39s the patch passed
_ Other Tests _
-1 ❌ unit 230m 58s root in the patch failed.
260m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5490
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4aaa58408dd8 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 57fea96
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/testReport/
Max. process+thread count 8291 (vs. ulimit of 30000)
modules C: hbase-zookeeper hbase-server hbase-it . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 1, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 20s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 2m 20s branch-2.4 passed
+1 💚 compile 1m 12s branch-2.4 passed
+1 💚 shadedjars 4m 11s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 1s branch-2.4 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 1m 54s the patch passed
+1 💚 compile 1m 15s the patch passed
+1 💚 javac 1m 15s the patch passed
+1 💚 shadedjars 4m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 1s the patch passed
_ Other Tests _
-1 ❌ unit 263m 19s root in the patch failed.
292m 56s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5490
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3b85b7578f00 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 57fea96
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/testReport/
Max. process+thread count 6125 (vs. ulimit of 30000)
modules C: hbase-zookeeper hbase-server hbase-it . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 1, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 15s branch-2.4 passed
+1 💚 compile 6m 22s branch-2.4 passed
+1 💚 spotless 0m 55s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 3m 19s the patch passed
+1 💚 compile 6m 9s the patch passed
+1 💚 javac 6m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 6s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 19m 53s Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
44m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5490
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 43f9c7167f81 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 57fea96
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-zookeeper hbase-server hbase-it . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 1, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 45s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for branch
+1 💚 mvninstall 2m 9s branch-2.4 passed
+1 💚 compile 1m 11s branch-2.4 passed
+1 💚 shadedjars 4m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 0s branch-2.4 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 1m 52s the patch passed
+1 💚 compile 1m 16s the patch passed
+1 💚 javac 1m 16s the patch passed
+1 💚 shadedjars 4m 16s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 2s the patch passed
_ Other Tests _
-1 ❌ unit 317m 4s root in the patch failed.
343m 35s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5490
Optional Tests javac javadoc unit shadedjars compile
uname Linux 515db0dc3f45 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 57fea96
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/2/testReport/
Max. process+thread count 7046 (vs. ulimit of 30000)
modules C: hbase-zookeeper hbase-server hbase-it . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5490/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Nov 2, 2023

The UT fails consistenctly, even on branch-2.4. Not sure why it does not appear on the flaky dashboard.

@NihalJain FYI, maybe we need your help on backporting the related fix to branch-2.5 and branch-2.4.

Let me merge. Thanks @apurtell for reviewing!

@Apache9 Apache9 merged commit 373b8b8 into apache:branch-2.4 Nov 2, 2023
@NihalJain
Copy link
Contributor

NihalJain commented Nov 2, 2023

@NihalJain FYI, maybe we need your help on backporting the related fix to branch-2.5 and branch-2.4.

Sure will have a look and raise backport soon.

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9 @anmolnar
HBASE-28153 Upgrade zookeeper to a newer version (apache#5484) (apach…
d0e5648 
…e#5490)

Backport of apache#5475

(cherry picked from commit 0d04a60)

Signed-off-by: Andrew Purtell <[email protected]>
Change-Id: Idb37274228e07afeea5518a1c79d4a053be46a05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtell apurtell apurtell approved these changes

Assignees

@Apache9 Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9 @Apache-HBase @NihalJain @apurtell