Skip to content

HBASE-28157. hbck should report previously reported regions with null region location #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apurtell merged 1 commit into from
Oct 25, 2023
Merged

HBASE-28157. hbck should report previously reported regions with null region location #5463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/hbck/HbckChore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,7 @@ private void loadRegionsFromRSReport(final HbckReport report) {

for (Map.Entry<String, HbckRegionInfo> entry : report.getRegionInfoMap().entrySet()) {
HbckRegionInfo hri = entry.getValue();
ServerName locationInMeta = hri.getMetaEntry().getRegionServer();
if (locationInMeta == null) {
continue;
}
ServerName locationInMeta = hri.getMetaEntry().getRegionServer(); // can be null
if (hri.getDeployedOn().size() == 0) {
// skip the offline region which belong to disabled table.
if (report.getDisabledTableRegions().contains(hri.getRegionNameAsString())) {
Expand Down
4 changes: 4 additions & 0 deletions hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,13 @@
* If a live server reference, make it a link.
* If dead, make it italic.
* If unknown, make it plain.
* If null, make it "null".
*/
private static String formatServerName(HMaster master,
ServerManager serverManager, ServerName serverName) {
if (serverName == null) {
return "null";
}
String sn = serverName.toString();
if (serverManager.isServerOnline(serverName)) {
int infoPort = master.getRegionServerInfoPort(serverName);
Expand Down
7 changes: 7 additions & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestHbckChore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,13 @@ public void testForUserTable() throws Exception {
hbckChore.choreForTesting();
inconsistentRegions = hbckChore.getLastReport().getInconsistentRegions();
assertFalse(inconsistentRegions.containsKey(regionName));

// Test for case4: No region location for a previously reported region. Probably due to
// TRSP bug or bypass.
am.offlineRegion(hri);
hbckChore.choreForTesting();
inconsistentRegions = hbckChore.getLastReport().getInconsistentRegions();
assertTrue(inconsistentRegions.containsKey(regionName));
}

@Test
Expand Down