Skip to content

HBASE-27920:Skipping compact for this region if the table disable compaction #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Apache9 merged 4 commits into from
Jul 6, 2023
Merged

HBASE-27920:Skipping compact for this region if the table disable compaction #5273

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a170072
Skipping compact if table disable compactin
guluo2016 Jun 7, 2023
a0acea6
Merge branch 'apache:master' into compaction
guluo2016 Jun 7, 2023
93b3040
Update code comments
guluo2016 Jun 7, 2023
d2f34b9
update comment
guluo2016 Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,8 +1638,8 @@ private static class CompactionChecker extends ScheduledChore {
@Override
protected void chore() {
for (Region r : this.instance.onlineRegions.values()) {
// Skip compaction if region is read only
if (r == null || r.isReadOnly()) {
// Skip compaction if region is read only or table disable compaction
Copy link
Contributor

@wchevreuil wchevreuil Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more clear:
// If region is read only or compaction is disabled at table level, there's no need to iterate through region's stores

if (r == null || r.isReadOnly() || !r.getTableDescriptor().isCompactionEnabled()) {
continue;
}

Expand Down