Skip to content

HBASE-27565 Make the initial corePoolSize configurable for ChoreService #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petersomogyi merged 1 commit into from
Jan 12, 2023
Merged

HBASE-27565 Make the initial corePoolSize configurable for ChoreService #4958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ public class ChoreService {
*/
@InterfaceAudience.Private
public final static int MIN_CORE_POOL_SIZE = 1;
/**
* The initial number of threads in the core pool for the {@link ChoreService}.
*/
public static final String CHORE_SERVICE_INITIAL_POOL_SIZE =
"hbase.choreservice.initial.pool.size";
public static final int DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE = 1;

/**
* This thread pool is used to schedule all of the Chores
Expand Down
6 changes: 5 additions & 1 deletion hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
*/
package org.apache.hadoop.hbase;

import static org.apache.hadoop.hbase.ChoreService.CHORE_SERVICE_INITIAL_POOL_SIZE;
import static org.apache.hadoop.hbase.ChoreService.DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE;
import static org.apache.hadoop.hbase.HConstants.DEFAULT_HBASE_SPLIT_COORDINATED_BY_ZK;
import static org.apache.hadoop.hbase.HConstants.HBASE_SPLIT_WAL_COORDINATED_BY_ZK;

Expand Down Expand Up @@ -278,7 +280,9 @@ public HBaseServerBase(Configuration conf, String name) throws IOException {

initializeFileSystem();

this.choreService = new ChoreService(getName(), true);
int choreServiceInitialSize =
conf.getInt(CHORE_SERVICE_INITIAL_POOL_SIZE, DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE);
this.choreService = new ChoreService(getName(), choreServiceInitialSize, true);
this.executorService = new ExecutorService(getName());

this.metaRegionLocationCache = new MetaRegionLocationCache(zooKeeper);
Expand Down