Skip to content

HBASE-27491: do not clear cache on RejectedExecutionException #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbeaudreault merged 2 commits into from
Dec 9, 2022
+18 −8
Merged

HBASE-27491: do not clear cache on RejectedExecutionException #4914

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
064d9b5
HBASE-27491: do not clear cache on RejectedExecutionException
Dec 5, 2022
70a2f1a
PR feedback
Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,17 +715,24 @@ private void receiveGlobalFailure(MultiAction rsActions, ServerName server, int
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES : Retry.NO_RETRIES_EXHAUSTED;

cleanServerCache(server, t);
// Do not update cache if exception is from failing to submit action to thread pool
if (!(t instanceof RejectedExecutionException)) {

@bbeaudreault bbeaudreault Dec 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this receiveGlobalFailure method is private and only called in 3 places. Rather than add another two instanceof checks here, thoughts on just adding a boolean argument to the method shouldClearCache? We can pass in false everywhere, except in the place where we already instanceof RejectedExecutionException in sendMultiAction

cleanServerCache(server, t);
}

int failed = 0;
int stopped = 0;
List<Action> toReplay = new ArrayList<>();
for (Map.Entry<byte[], List<Action>> e : rsActions.actions.entrySet()) {
byte[] regionName = e.getKey();
byte[] row = e.getValue().get(0).getAction().getRow();
// Do not use the exception for updating cache because it might be coming from
// any of the regions in the MultiAction.
updateCachedLocations(server, regionName, row,
ClientExceptionsUtil.isMetaClearingException(t) ? null : t);
// any of the regions in the MultiAction and do not update cache if exception is
// from failing to submit action to thread pool
if (!(t instanceof RejectedExecutionException)) {
updateCachedLocations(server, regionName, row,
ClientExceptionsUtil.isMetaClearingException(t) ? null : t);
}
for (Action action : e.getValue()) {
Retry retry =
manageError(action.getOriginalIndex(), action.getAction(), canRetry, t, server);
Expand Down