Skip to content

[HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apurtell merged 2 commits into from
Aug 22, 2019
Merged

[HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. #490

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1265220
[HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.
Aug 13, 2019
c4bafbe
[HBASE-22601] Addresing review comments.
Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...ver/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,15 @@ public void run() {
}
}

if (peerClusterId == null) {
// In some cases, it is possible that peerClusterId is null because it couldn't read
// peer cluster id from zookeeper. One case this might happen is because 2 clusters don't
// have kerberos trust setup.
this.terminate("Peer ClusterId returned is null", null, false);
this.manager.closeQueue(this);
return;
}

// In rare case, zookeeper setting may be messed up. That leads to the incorrect
// peerClusterId value, which is the same as the source clusterId
if (clusterId.equals(peerClusterId) && !replicationEndpoint.canReplicateToSameCluster()) {
Expand Down