Skip to content

HBASE-27422: Support replication for hbase:acl #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchevreuil merged 1 commit into from
Apr 14, 2023
Merged

HBASE-27422: Support replication for hbase:acl #4827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...e-server/src/main/java/org/apache/hadoop/hbase/replication/SystemTableWALEntryFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,28 @@
*/
package org.apache.hadoop.hbase.replication;

import org.apache.hadoop.hbase.security.access.PermissionStorage;
import org.apache.hadoop.hbase.security.visibility.VisibilityConstants;
import org.apache.hadoop.hbase.wal.WAL.Entry;
import org.apache.yetus.audience.InterfaceAudience;

/**
* Skips WAL edits for all System tables including hbase:meta.
* Skips WAL edits for all System tables including hbase:meta except hbase:acl. As of now, only 2
* tables can be allowed for replication - hbase:acl and hbase:labels. Other tables which not be
* replicated are 1. hbase:meta - not to be replicated 2. hbase:canary - for current cluster 3.
* hbase:namespace - Deprecated and moved to meta 4. hbase:quota - related to namespace, quota for
* the current cluster usage 5. hbase:rsgroup - contains hostnames
*/
@InterfaceAudience.Private
public class SystemTableWALEntryFilter implements WALEntryFilter {
@Override
public Entry filter(Entry entry) {
if (
entry.getKey().getTableName().equals(PermissionStorage.ACL_TABLE_NAME)
|| entry.getKey().getTableName().equals(VisibilityConstants.LABELS_TABLE_NAME)
) {
return entry;
}
return entry.getKey().getTableName().isSystemTable() ? null : entry;
}
}
14 changes: 14 additions & 0 deletions ...ver/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationWALEntryFilters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
import org.apache.hadoop.hbase.KeyValue;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.client.RegionInfoBuilder;
import org.apache.hadoop.hbase.security.access.PermissionStorage;
import org.apache.hadoop.hbase.security.visibility.VisibilityConstants;
import org.apache.hadoop.hbase.testclassification.ReplicationTests;
import org.apache.hadoop.hbase.testclassification.SmallTests;
import org.apache.hadoop.hbase.util.Bytes;
Expand Down Expand Up @@ -80,6 +82,18 @@ public void testSystemTableWALEntryFilter() {
Entry userEntry = new Entry(key3, null);

assertEquals(userEntry, filter.filter(userEntry));

// hbase:acl should be allowed through the filter
WALKeyImpl key4 =
new WALKeyImpl(new byte[0], PermissionStorage.ACL_TABLE_NAME, System.currentTimeMillis());
Entry aclEntry = new Entry(key4, null);
assertEquals(aclEntry, filter.filter(aclEntry));

// hbase:labels should be allowed through the filter
WALKeyImpl key5 = new WALKeyImpl(new byte[0], VisibilityConstants.LABELS_TABLE_NAME,
System.currentTimeMillis());
Entry labelsEntry = new Entry(key5, null);
assertEquals(labelsEntry, filter.filter(labelsEntry));
}

@Test
Expand Down