Skip to content

HBASE-27339 Improve sasl connection failure log message to include server #4823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apurtell merged 3 commits into from
Oct 11, 2022
Merged

HBASE-27339 Improve sasl connection failure log message to include server #4823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a9fbaa
HBASE-27339 Improve sasl connection failure log message to include se…
apurtell Oct 11, 2022
93a23de
Fix pasto
apurtell Oct 11, 2022
e14b2b5
Spotless fixes
apurtell Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ public Object run() throws IOException, InterruptedException {
// A provider which failed authentication, but doesn't have the ability to relogin with
// some external system (e.g. username/password, the password either works or it doesn't)
if (!provider.canRetry()) {
LOG.warn("Exception encountered while connecting to the server : " + ex);
LOG.warn("Exception encountered while connecting to the server " + remoteId.getAddress(), ex);
if (ex instanceof RemoteException) {
throw (RemoteException) ex;
}
Expand All @@ -410,7 +410,7 @@ public Object run() throws IOException, InterruptedException {
// Other providers, like kerberos, could request a new ticket from a keytab. Let
// them try again.
if (currRetries < maxRetries) {
LOG.debug("Exception encountered while connecting to the server", ex);
LOG.debug("Exception encountered while connecting to the server " + remoteId.getAddress(), ex);

// Invoke the provider to perform the relogin
provider.relogin();
Expand Down
4 changes: 3 additions & 1 deletion hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,9 @@ private void succeed(Channel ch) throws IOException {
}

private void fail(Channel ch, Throwable error) {
failInit(ch, toIOE(error));
IOException ex = toIOE(error);
LOG.warn("Exception encountered while connecting to the server " + remoteId.getAddress(), ex);
failInit(ch, toIOE(ex));

@Apache9 Apache9 Oct 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be failInit(ch, ex)?

@virajjasani virajjasani Oct 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, once this is addressed, +1 for the PR

@apurtell apurtell Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the nit, merging.

rpcClient.failedServers.addToFailedServers(remoteId.getAddress(), error);
}

Expand Down