Skip to content

Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2 #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndimiduk merged 1 commit into from
Aug 17, 2022
Merged

Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2 #4706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,9 @@ protected boolean performCompaction(FileDetails fd, InternalScanner scanner, Cel
mobRefSet.get().put(refTable.get(), fName);
writer.append(c);
} else {
throw new IOException("MOB cell did not contain a tablename "
throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. "
+ "store=" + getStoreInfo() + " cell=" + c);
+ "store=%s cell=%s", getStoreInfo(), c));
}
}
}
Expand Down Expand Up @@ -495,9 +495,9 @@ protected boolean performCompaction(FileDetails fd, InternalScanner scanner, Cel
mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c));
writer.append(c);
} else {
throw new IOException("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. " + "store="
+ getStoreInfo() + " cell=" + c);
throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. "
+ "store=%s cell=%s", getStoreInfo(), c));
}
} else {
String errMsg = String.format("Corrupted MOB reference: %s", c.toString());
Expand Down
8 changes: 4 additions & 4 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,9 @@ protected boolean performCompaction(FileDetails fd, InternalScanner scanner, Cel
mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c));
writer.append(c);
} else {
throw new IOException("MOB cell did not contain a tablename "
throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. "
+ "store=" + getStoreInfo() + " cell=" + c);
+ "store=%s cell=%s", getStoreInfo(), c));
}
} else {
// If the value is not larger than the threshold, it's not regarded a mob. Retrieve
Expand All @@ -270,9 +270,9 @@ protected boolean performCompaction(FileDetails fd, InternalScanner scanner, Cel
mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c));
writer.append(c);
} else {
throw new IOException("MOB cell did not contain a tablename "
throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. "
+ "store=" + getStoreInfo() + " cell=" + c);
+ "store=%s cell=%s", getStoreInfo(), c));
}
}
}
Expand Down