Skip to content

HBASE-27117 Update the method comments for RegionServerAccounting #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
virajjasani merged 1 commit into from
Jun 17, 2022
Merged

HBASE-27117 Update the method comments for RegionServerAccounting #4532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,14 +432,14 @@ private boolean refreshStoreFilesAndReclaimMemory(Region region) {
}

/**
* Return true if global memory usage is above the high watermark
* Return the FlushType if global memory usage is above the high watermark
*/
private FlushType isAboveHighWaterMark() {
return server.getRegionServerAccounting().isAboveHighWaterMark();
}

/**
* Return true if we're above the low watermark
* Return the FlushType if we're above the low watermark
*/
private FlushType isAboveLowWaterMark() {
return server.getRegionServerAccounting().isAboveLowWaterMark();
Expand Down
7 changes: 4 additions & 3 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAccounting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ public void decGlobalMemStoreSize(long dataSizeDelta, long heapSizeDelta, long o
}

/**
* Return true if we are above the memstore high water mark
* @return the flushtype
* Return the FlushType if we are above the memstore high water mark
* @return the FlushType
*/
public FlushType isAboveHighWaterMark() {
// for onheap memstore we check if the global memstore size and the
Expand Down Expand Up @@ -193,7 +193,8 @@ public FlushType isAboveHighWaterMark() {
}

/**
* Return true if we're above the low watermark
* Return the FlushType if we're above the low watermark
* @return the FlushType
*/
public FlushType isAboveLowWaterMark() {
// for onheap memstore we check if the global memstore size and the
Expand Down