Skip to content

Hbase 26275, update error message when executing deleteall with ROWPREFIXFILTER in meta table #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunhelly merged 7 commits into from
Mar 16, 2022
Merged

Hbase 26275, update error message when executing deleteall with ROWPREFIXFILTER in meta table #4205

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6c46cf
Merge pull request #1 from apache/master
xicm Nov 16, 2021
13e75fa
Merge branch 'apache:master' into master
xicm Mar 3, 2022
b22f86f
Merge branch 'apache:master' into master
xicm Mar 4, 2022
e497ed1
Merge branch 'apache:master' into master
xicm Mar 10, 2022
f3485e5
Merge branch 'apache:master' into master
xicm Mar 11, 2022
e0c3fca
HBASE-26275, ROWPREFIXFILTER doesn't work when execute deleteall with…
xicm Mar 11, 2022
9479ab6
HBASE-26275, update error message of deleteall
xicm Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-shell/src/main/ruby/hbase/table.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def _deleteall_internal(row, column = nil,
args = {}, all_version = true)
# delete operation doesn't need read permission. Retaining the read check for
# meta table as a part of HBASE-5837.
if is_meta_table?
if is_meta_table? and !(row.is_a?(Hash) and row.key?('ROWPREFIXFILTER'))
Copy link
Contributor

@sunhelly sunhelly Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dangerous to delete rows in meta table by 'ROWPREFIXFILTER', right? If the rowPrefix matches some rows unexpected, the meta data will be deleted unexpected. I think maybe this is why the origin design seperated meta table here.

Copy link
Contributor Author

@xicm xicm Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have this concen too. Let me fix the error message?

Copy link
Contributor

@sunhelly sunhelly Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, you can try to make the descriptions more clearly.

raise ArgumentError, 'Row Not Found' if _get_internal(row).nil?
end
if row.is_a?(Hash)
Expand Down
11 changes: 11 additions & 0 deletions hbase-shell/src/test/ruby/hbase/table_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,17 @@ def teardown
assert_nil(res2)
end

define_test "deleteall should work with row prefix in hbase:meta" do
@meta_table = table('hbase:meta')
@meta_table.put("test_meta_1", "table:state", "\x08\x01")
@meta_table.put("test_meta_2", "table:state", "\x08\x01")
@meta_table.deleteall({ROWPREFIXFILTER => "test_meta"})
res1 = @test_table._get_internal('test_meta_1')
assert_nil(res1)
res2 = @test_table._get_internal('test_meta_2')
assert_nil(res2)
end

define_test "append should work with value" do
@test_table.append("123", 'x:cnt2', '123')
assert_equal("123123", @test_table._append_internal("123", 'x:cnt2', '123'))
Expand Down