HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down #4072

YutSean · 2022-01-27T05:48:44Z

https://issues.apache.org/jira/browse/HBASE-26688

Apache-HBase · 2022-01-27T06:53:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 1s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 35s	master passed
+1 💚	compile	4m 33s	master passed
+1 💚	checkstyle	1m 44s	master passed
+1 💚	spotbugs	3m 32s	master passed
-0 ⚠️	patch	2m 40s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 27s	the patch passed
+1 💚	compile	4m 32s	the patch passed
+1 💚	javac	4m 32s	the patch passed
+1 💚	checkstyle	0m 29s	hbase-client: The patch generated 0 new + 11 unchanged - 2 fixed = 11 total (was 13)
-0 ⚠️	checkstyle	1m 9s	hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 11s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	3m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		62m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4072
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 4dae62b12b3a 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6348d4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-01-27T09:27:46Z

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java

  }

-  @Test
-  public void testAdvanceTwiceOnEmptyCell() throws IOException {


Better keep this test but use two assertFalse to confirm that the second advance call will return false?

Better keep this test but use two assertFalse to confirm that the second advance call will return false?

After the change, empty list will always return false. I think we could change the UT's name to testAdvanceMultipieOnEmptyCell and use an arbitrary value > 2 to assert false. What do you think?

It is also fine. Just go ahead.

Apache-HBase · 2022-01-27T09:59:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 18s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	9m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	master passed
-0 ⚠️	patch	10m 37s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 5s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	9m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-client in the patch passed.
-1 ❌	unit	208m 5s	hbase-server in the patch failed.
		248m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4072
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ca28ce3918f0 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6348d4`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/testReport/
Max. process+thread count	3729 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… job down

Apache-HBase · 2022-01-27T10:48:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 5s	master passed
+1 💚	compile	1m 51s	master passed
+1 💚	shadedjars	9m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 12s	master passed
-0 ⚠️	patch	11m 32s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	1m 47s	the patch passed
+1 💚	javac	1m 47s	the patch passed
+1 💚	shadedjars	9m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 48s	hbase-client in the patch passed.
-1 ❌	unit	254m 6s	hbase-server in the patch failed.
		297m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4072
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 873c4c018138 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6348d4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/testReport/
Max. process+thread count	2892 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4072/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 reviewed Jan 27, 2022

View reviewed changes

YutSean changed the title ~~HBASE-26688 Result#advance, current are not thread safe. But the pre-created EMPTY_RESULT like objects can be shared by multi client threads~~ HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down Jan 27, 2022

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client…

6dabd2e

… job down

YutSean force-pushed the HBASE-26688-master branch from 0d9b4d6 to 6dabd2e Compare January 27, 2022 10:13

YutSean closed this Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down #4072

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down #4072

Uh oh!

YutSean commented Jan 27, 2022

Uh oh!

Apache-HBase commented Jan 27, 2022

Uh oh!

Apache9 Jan 27, 2022

Uh oh!

YutSean Jan 27, 2022

Uh oh!

Apache9 Jan 27, 2022

Uh oh!

Apache-HBase commented Jan 27, 2022

Uh oh!

Apache-HBase commented Jan 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down #4072

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down #4072

Uh oh!

Conversation

YutSean commented Jan 27, 2022

Uh oh!

Apache-HBase commented Jan 27, 2022

Uh oh!

Apache9 Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

YutSean Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

Apache9 Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 27, 2022

Uh oh!

Apache-HBase commented Jan 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants