-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-26339 SshPublisher will skip uploading artifacts if the build i… #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
This is the pre commit result And for nightlies build There were errors when running junit for JDK11 hadoop3, but we still uploaded the test logs to nightlies So I think ithe PR could solve the problem describe in the jira issue. Thanks. |
joshelser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes me wish that script had a built-in callback you could give it if the script returned non-zero, but alas.
LGTM
ndimiduk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, yeah, let's use it. I wonder though, when is post { always { ... } } supposed to run, if not "always" ?
busbey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof. thanks for including the comment about why we're doing this.
…s failure (#3736) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
…s failure (#3736) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
…s failure (#3736) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
…s failure (#3736) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
…s failure (#3736) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
…s failure (apache#3736) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
…s failure (apache#3736) Signed-off-by: Josh Elser <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
…s failure