Skip to content

Conversation

@bitterfox
Copy link
Contributor

@bitterfox bitterfox commented Sep 11, 2021

https://issues.apache.org/jira/browse/HBASE-26272

The principal parsing is failing with KerberosName's default rule that relies on the default realm.

It's caused by missing apache/hadoop@be38e53#diff-4fe7835f2ef9e7512e198edee5ed08b8d0685977efd3434eadfbd612fd4dc768 in branch-2's hadoop librarry

This change affects the difference in behavior.

  • In branch-2 (without be38e530bb23b134758e29c9101f98cf4e1d2c38)
    • It takes default realm at reset
    • KDC and Kerberos config for EXAMPLE.COM is not yet provided at that timing
    • (So need to reset again after KDC and Kerberos config are prepared)
  • In master (with be38e530bb23b134758e29c9101f98cf4e1d2c38)
    • It just set null to default realm at reset
    • default realm is taken when getDefaultRealm is called (i.e. parsing kerberos principal name)
    • At that time, there's correct default realm(EXAMPLE.COM) is provided in Kerberos config

Also fix the shutdown order, shutdown KDC before testing cluster, somehow the different order causes exception in branch-2, though it doesn't in master.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 14s branch-2 passed
+1 💚 compile 0m 50s branch-2 passed
+1 💚 checkstyle 0m 20s branch-2 passed
+1 💚 spotbugs 0m 48s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 42s the patch passed
+1 💚 compile 0m 47s the patch passed
+1 💚 javac 0m 47s the patch passed
+1 💚 checkstyle 0m 19s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 3s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 55s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
34m 50s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3676
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux d4fc3a075a25 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 126f6bc
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 25s branch-2 passed
+1 💚 compile 0m 29s branch-2 passed
+1 💚 shadedjars 7m 15s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 25s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 2s the patch passed
+1 💚 compile 0m 30s the patch passed
+1 💚 javac 0m 30s the patch passed
+1 💚 shadedjars 7m 16s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s the patch passed
_ Other Tests _
+1 💚 unit 11m 42s hbase-mapreduce in the patch passed.
38m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3676
Optional Tests javac javadoc unit shadedjars compile
uname Linux 363405f06b99 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 126f6bc
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/testReport/
Max. process+thread count 3905 (vs. ulimit of 12500)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 6s branch-2 passed
+1 💚 compile 0m 25s branch-2 passed
+1 💚 shadedjars 7m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 20s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 44s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 shadedjars 7m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 17s the patch passed
_ Other Tests _
+1 💚 unit 16m 43s hbase-mapreduce in the patch passed.
43m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3676
Optional Tests javac javadoc unit shadedjars compile
uname Linux a51cf1f7bc9e 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 126f6bc
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/testReport/
Max. process+thread count 2344 (vs. ulimit of 12500)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3676/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this.

@Apache9 Apache9 changed the title HBASE-26272 Fix TestTableMapReduceUntil failure in branch-2 HBASE-26272 TestTableMapReduceUtil failure in branch-2 Sep 13, 2021
@Apache9
Copy link
Contributor

Apache9 commented Sep 13, 2021

Tried locally, it can fix the broken TestTableMapReduceUtil. Let me merge and cherry-pick to branch-2.3+.

@Apache9 Apache9 merged commit e139d31 into apache:branch-2 Sep 13, 2021
Apache9 pushed a commit that referenced this pull request Sep 13, 2021
Apache9 pushed a commit that referenced this pull request Sep 13, 2021
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants