-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-26255 Add an option to use region location from meta table in T… #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
cb258fe to
d5d8cf0
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
| Connection connection; | ||
| RegionLocator regionLocator = null; | ||
| if (localityEnabled && useRegionLoc) { | ||
| connection = ConnectionFactory.createConnection(new Configuration(conf)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this connection?
Also on this connection, we will make calls to read from hbase:meta only. We can set connection executor pool size with lowering value for 'hbase.hconnection.threads.max'? We allow core threads to die but initially will create more threads (256).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, let me upload a new patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anoopsjohn, I pushed updates based on your comment, please take a look, thanks.
…ableSnapshotInputFormat
d5d8cf0 to
392c291
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…ableSnapshotInputFormat (apache#3661) Signed-off-by: Anoop Sam John <[email protected]>
…ableSnapshotInputFormat (apache#3661) Signed-off-by: Anoop Sam John <[email protected]>
…ableSnapshotInputFormat (apache#3661) Signed-off-by: Anoop Sam John <[email protected]>
…ableSnapshotInputFormat (#3661) (#3670) Signed-off-by: Anoop Sam John <[email protected]>
…ableSnapshotInputFormat (#3661) (#3668) Signed-off-by: Anoop Sam John <[email protected]>
…ableSnapshotInputFormat (#3661) (#3669) Signed-off-by: Anoop Sam John <[email protected]>
…ableSnapshotInputFormat (apache#3661) (apache#3669) Signed-off-by: Anoop Sam John <[email protected]>
…ableSnapshotInputFormat