-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-26215 The backup master status page should use ActiveMasterManager instead of MasterAddressTracker #3621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ger instead of MasterAddressTracker
Apache9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Just a minor nit.
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Is this issue branch-2 specific? Usually we should open a PR against master branch first, unless the issue is specific to some branches. Thanks. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Oh, wrong place, I was trying to reply to another PR, sorry... |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…ger instead of MasterAddressTracker (#3621) Signed-off-by: Duo Zhang <[email protected]>
Since the backup master status page will remove the MasterAddressTracker, and there is no direct method to obtain ActiveMasterManager (I saw that ActiveMasterManager is a private member of HMaster, and all values in ActiveMasterManager should be returned through HMaster’s public methods). I added some code to make the backup master status page easily retrieve the information it needs.