HBASE-26079 Use StoreFileTracker when splitting and merging #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Aug 24, 2021
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java
Outdated
Show resolved
Hide resolved
| throw new IOException("Unable to rename " + mergedRegionTmpDir + " to " | ||
| + regionDir); | ||
| } | ||
| loadRegionFilesIntoStoreTracker(regionDir); |
Contributor
There was a problem hiding this comment.
I think we should also get the file list from store file tracker instead of listing?
Contributor
Author
There was a problem hiding this comment.
These would not be in the tracker yet, as these are the links created in this split/merge operation.
Contributor
There was a problem hiding this comment.
I mean, when splitting/merging, we will create the linked store files in memory, we should just use them to insert to the tracker, so we do not need to list again.
...main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Sorry, missed your ping there. Let me take a look. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…racking logic Signed-off-by: Wellington Chevreuil <[email protected]>
added 2 commits
August 25, 2021 11:33
Change-Id: I1801bd4d1078c5967e2f80646cb1d40be12d9829
Change-Id: I89326af60c4e19f6dff0a0c517b826b17947b264
…store trakcer Change-Id: If5431fea9326c30e932b74e563dabcabc2a82c2f
wchevreuil
force-pushed
the
HBASE-26079
branch
from
6d40c8d to
a66cecc
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Change-Id: I144a978fa4d2d35cdade60d98f5e6e7d503a49de
wchevreuil
force-pushed
the
HBASE-26079
branch
from
e92f501 to
888f140
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Aug 26, 2021
| trackerMap.computeIfAbsent(familyName, t -> { | ||
| ColumnFamilyDescriptorBuilder fDescBuilder = | ||
| ColumnFamilyDescriptorBuilder.newBuilder(Bytes.toBytes(familyName)); | ||
| return StoreFileTrackerFactory.create(conf, regionInfo.getTable(), true, |
Contributor
There was a problem hiding this comment.
I think here when creating StoreFileTracker, we should use the modified Configuration instance where we also include the configurations declared in table description and family description, as you can set StoreEngine per table or family.
Contributor
Author
There was a problem hiding this comment.
Agreed. Had changed this on latest commit.
| List<Path> mergedFiles = new ArrayList<>(); | ||
| for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) { | ||
| String family = hcd.getNameAsString(); | ||
| final Collection<StoreFileInfo> storeFiles = regionFs.getStoreFiles(family); |
Contributor
There was a problem hiding this comment.
I think here we should use StoreFileTracker to get the file list, instead of loading from HRegionFileSystem?
Contributor
Author
There was a problem hiding this comment.
Yes, and same thing on splits. Had changed this on latest commit.
1) Changes to load files to split/merge from tracker, instead of listing from FS; 2) UT for above; 3) Changed tracker factory to load traker impl from CF first, then Table, then Configuration; Change-Id: I3a09afd28afe5fe6297b28dafa5dec0eca4c323c
wchevreuil
force-pushed
the
HBASE-26079
branch
from
4af7ec4 to
c39ad64
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.