HBASE-22582 The Compaction writer may access the lastCell whose memor… #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openinx
requested review from
Apache9,
anoopsjohn,
infraio,
ramkrish86 and
saintstack
Member
Author
|
Will try to add few UT to address this bug. |
|
🎊 +1 overall
This message was automatically generated. |
Member
|
@openinx , I see some syntax/style fixes along with the "beforeShipped()" fix. I can confirm that there are other places as well in these 3 files were such changes could be welcomed. Do you think that we should include those as well here? |
Member
Author
|
@jatsakthi Yeah, I think we can fix the checksytle in this issue. |
anoopsjohn
reviewed
Jun 27, 2019
| "Interrupted while control throughput of compacting " + compactionName); | ||
| } finally { | ||
| throughputController.finish(compactionName); | ||
| ((ShipperListener) writer).beforeShipped(); |
Contributor
There was a problem hiding this comment.
Below in Compactor, call beforeShipped() before finishing the throughputController. Its ok for any order. Still we can maintain one order.
Member
Author
There was a problem hiding this comment.
Yeah, I will provide a UT to address this bug but am working on other things now... will update this patch later.
anoopsjohn
reviewed
Jun 27, 2019
| + String.format(", rate=%.2f kB/sec", (bytesWrittenProgressForLog / 1024.0) | ||
| / ((now - lastMillis) / 1000.0)) + ", throughputController is " | ||
| + throughputController); | ||
| double rate = (bytesWrittenProgressForLog / 1024.0) / ((now - lastMillis) / 1000.0); |
Contributor
There was a problem hiding this comment.
What abt the String formatting on the Double value which we were doing. Missing that in log now. Below one more place too.
Member
Author
There was a problem hiding this comment.
Emm... maybe I need to format the rate first before put it as a arg in LOG.debug, thanks .
|
💔 -1 overall
This message was automatically generated. |
infraio
reviewed
Jul 4, 2019
| + String.format(", rate=%.2f kB/sec", (bytesWrittenProgressForLog / 1024.0) | ||
| / ((now - lastMillis) / 1000.0)) + ", throughputController is " | ||
| + throughputController); | ||
| String rate = String.format("%.2f", |
Contributor
There was a problem hiding this comment.
if (LOG.isDebugEnabled())? Then can skip to generate "rate" String in production environment.
Member
Author
There was a problem hiding this comment.
Have an existed isDebugEnabled before in line#312 :-)
infraio
reviewed
Jul 4, 2019
| + String.format(", rate=%.2f kB/sec", (bytesWrittenProgressForLog / 1024.0) | ||
| / ((now - lastMillis) / 1000.0)) + ", throughputController is " | ||
| + throughputController); | ||
| String rate = String.format("%.2f", |
Contributor
There was a problem hiding this comment.
Ditto. if (LOG.isDebugEnabled())?
infraio
reviewed
Jul 4, 2019
| throw new InterruptedIOException( | ||
| "Interrupted while control throughput of compacting " + compactionName); | ||
| } finally { | ||
| ((ShipperListener) writer).beforeShipped(); |
…y has been released when appending fileInfo in the final
infraio
approved these changes
Jul 4, 2019
asfgit
pushed a commit
that referenced
this pull request
Jul 4, 2019
…y has been released when appending fileInfo in the final (#341)
asfgit
pushed a commit
that referenced
this pull request
Jul 4, 2019
…y has been released when appending fileInfo in the final (#341)
asfgit
pushed a commit
that referenced
this pull request
Jul 4, 2019
…y has been released when appending fileInfo in the final (#341)
asfgit
pushed a commit
that referenced
this pull request
Jul 4, 2019
…y has been released when appending fileInfo in the final (#341)
|
💔 -1 overall
This message was automatically generated. |
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…y has been released when appending fileInfo in the final (apache#341)
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…y has been released when appending fileInfo in the final (apache#341) (cherry picked from commit 77e5e5c) Change-Id: Id64bb99efa1b9916189e7179fd316be932ece093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y has been released when appending fileInfo in the final