Skip to content

[HBASE-22592] : HMaster Construction failure stacktrace to be availab… #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
virajjasani wants to merge 4 commits into from
Closed

[HBASE-22592] : HMaster Construction failure stacktrace to be availab… #311

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32930cc
[HBASE-22592] : HMaster Construction failure stacktrace to be availab…
virajjasani Jun 16, 2019
cd57f79
commit to retrigger build
virajjasani Jun 17, 2019
ca5239e
Merge branch 'master' of github.com:apache/hbase into HBASE-22592-master
virajjasani Jun 17, 2019
5cf03fc
Merge branch 'master' of github.com:apache/hbase into HBASE-22592-master
virajjasani Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ private int startMaster() {
throw new RuntimeException("HMaster Aborted");
}
} catch (Throwable t) {
t.printStackTrace();
Copy link
Contributor

@HorizonNet HorizonNet Jun 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the error be present in the log files with this change? Is there a better way to do this, but still using the logger?

Copy link
Contributor Author

@virajjasani virajjasani Jun 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that but as per the screenshot provided in the description, the Exception provided is not available in log file because Logger is not yet loaded.
Anyways, adding printstacktrace() would ensure that the StackTrace is atleast available in .out file. If the Logger is created and loaded by that time, then it would also be present in .log file based on: LOG.error("Master exiting", t);

LOG.error("Master exiting", t);
return 1;
}
Expand Down