HBase 22537 #307

wchevreuil · 2019-06-14T17:57:09Z

This PR consists of two commits on top of branch-2.1:

Changes from original patch proposed by sreenivasulureddy;
My suggestion to just remove the "non-primary" replica from AM map of regions per RS.

I had proposed a minor change in my commit because original fix would cause region close notification eve for read replicas, I'm not sure this is ideal.

Additional work may be needed on existing test, so it may be easy to collaborate via this PR. I can then squash all commits into a single one once we are ready to apply the fix.

…leting table successfully and restarting RegionServer

...erver/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java

…de blocks, simplified util method for inserting data.

Apache-HBase · 2019-07-02T16:01:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ branch-2.1 Compile Tests _
+1	mvninstall	255	branch-2.1 passed
+1	compile	52	branch-2.1 passed
+1	checkstyle	80	branch-2.1 passed
+1	shadedjars	251	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	129	branch-2.1 passed
+1	javadoc	33	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	249	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	79	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	251	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1013	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	136	the patch passed
+1	javadoc	32	the patch passed
		_ Other Tests _
+1	unit	8314	hbase-server in the patch passed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		11346

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/3/artifact/out/Dockerfile
GITHUB PR	#307
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5ab1a4034771 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `35521d4`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/3/testReport/
Max. process+thread count	4608 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-02T17:56:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	77	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ branch-2.1 Compile Tests _
+1	mvninstall	315	branch-2.1 passed
+1	compile	81	branch-2.1 passed
+1	checkstyle	90	branch-2.1 passed
+1	shadedjars	307	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	173	branch-2.1 passed
+1	javadoc	42	branch-2.1 passed
		_ Patch Compile Tests _
+1	mvninstall	318	the patch passed
+1	compile	68	the patch passed
+1	javac	68	the patch passed
-1	checkstyle	92	hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	310	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1285	Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1	findbugs	191	the patch passed
+1	javadoc	39	the patch passed
		_ Other Tests _
-1	unit	14901	hbase-server in the patch failed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		18717

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.quotas.TestSpaceQuotas

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/artifact/out/Dockerfile
GITHUB PR	#307
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4976c0541afc 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-2.1 / `35521d4`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/testReport/
Max. process+thread count	5213 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…leting table successfully and restarting RegionServer Signed-off-by: Wellington Chevreuil <[email protected]>

…22537

…changes should be addressed on its own jira issue.

Apache-HBase · 2019-07-03T09:55:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	8	#307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#307
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Signed-off-by: Balazs Meszaros <[email protected]>

…ermissions on created table Signed-off-by: Reid Chan <[email protected]>

…APIs (apache#208) Signed-off-by: stack <[email protected]>

Signed-off-by: huzheng <[email protected]>

…hecker and PeriodicMemStoreFlusher Signed-off-by: Zach York <[email protected]> Signed-off-by: Xu Cang <[email protected]>

…rsions Signed-off-by: Sean Busbey <[email protected]> (cherry picked from commit 6a068da)

…pache#281) HBASE-22520 Avoid possible NPE while performing seekBefore in HalfStoreFileReader

* phrase fudge factor "deltas" in terms of the original period * increase the delta allowed for chore timing from 5% to 20% * improve some assertions Closes apache#328 Signed-off-by: Reid Chan <[email protected]> Signed-off-by: Sakthi <[email protected]> (cherry picked from commit 9aee88e)

…component ops (apache#329) Signed-off-by: Reid Chan <[email protected]> Signed-off-by: Michael Stack <[email protected]>

) Signed-off-by: Guanghao Zhang <[email protected]> Signed-off-by: Andrew Purtell <[email protected]>

…should skip store files for unknown column families (apache#344) Signed-off-by: Guanghao Zhang <[email protected]>

Signed-off-by: stack <[email protected]>

…tionQueueStorage Signed-off-by: Sakthi <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

…'s pendingAssginQueue is cleared

Signed-off-by: stack <[email protected]>

…in client registry may crash a master

…sign forever fail Signed-off-by: Allan Yang <[email protected]> Signed-off-by: Michael Stack <[email protected]>

Signed-off-by: Peter Somogyi <[email protected]> Signed-off-by: Sakthi <[email protected]>

Signed-off-by: Sean Busbey <[email protected]>

…able" by Jim R. Wilson Signed-off-by: Sean Busbey <[email protected]>

wchevreuil · 2019-07-03T14:11:25Z

Rebased this PR with branch-2.1.

Apache-HBase · 2019-07-03T14:25:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	7	#307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#307
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-03T16:15:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	9	#307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#307
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/6/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-12T20:14:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	8	#307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#307
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/7/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

sreenivasulureddy and others added 2 commits June 14, 2019 18:43

HBASE-22537 Split happened Replica region can not be deleted after de…

5e84291

…leting table successfully and restarting RegionServer

HBASE-22537 Minor suggestion to SREENIVASULU's original fix proposal

cad5ec3

wchevreuil commented Jun 14, 2019

View reviewed changes

...erver/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java Outdated Show resolved Hide resolved

wchevreuil commented Jun 14, 2019

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java Show resolved Hide resolved

wchevreuil commented Jun 14, 2019

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java Outdated Show resolved Hide resolved

wchevreuil commented Jun 14, 2019

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java Outdated Show resolved Hide resolved

wchevreuil commented Jun 14, 2019

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java Show resolved Hide resolved

wchevreuil added 2 commits July 2, 2019 13:43

moved test to TestSplitOrMergeStatus, removed unused variables and co…

41da963

…de blocks, simplified util method for inserting data.

cleaning out imports changes introduced on this PR.

e8893c8

sreenivasulureddy and others added 3 commits July 3, 2019 09:55

HBASE-22537 Split happened Replica region can not be deleted after de…

8bc7636

…leting table successfully and restarting RegionServer Signed-off-by: Wellington Chevreuil <[email protected]>

Merge branch 'HBASE-22537' of github.com:wchevreuil/hbase into HBASE-…

b61ac0d

…22537

reverting line break change on SplitTableRegionProcedure. Checkstyle …

2273ace

…changes should be addressed on its own jira issue.

HorizonNet and others added 15 commits July 3, 2019 15:08

HBASE-22593 Added Jenv file to gitignore (apache#314)

5b7c87a

Signed-off-by: Balazs Meszaros <[email protected]>

HBASE-22581 user with "CREATE" permission can grant, but not revoke p…

0de4c4c

…ermissions on created table Signed-off-by: Reid Chan <[email protected]>

HBASE-22344 Documented the deprecation of public and limited private …

a883f1d

…APIs (apache#208) Signed-off-by: stack <[email protected]>

HBASE-22561 modify HFilePrettyPrinter to accept non-rootdir directories

be06209

Signed-off-by: huzheng <[email protected]>

HBASE-22596 [Chore] Separate the execution period between CompactionC…

1dc0a2b

…hecker and PeriodicMemStoreFlusher Signed-off-by: Zach York <[email protected]> Signed-off-by: Xu Cang <[email protected]>

HBASE-22605 Ref guide includes dev guidance only applicable to EOM ve…

85eb24a

…rsions Signed-off-by: Sean Busbey <[email protected]> (cherry picked from commit 6a068da)

HBASE-22520 Avoid possible NPE while performing seekBefore in Hal… (a…

474cbc2

…pache#281) HBASE-22520 Avoid possible NPE while performing seekBefore in HalfStoreFileReader

HBASE-22616 responseTooXXX logging for Multi should characterize the …

298f135

…component ops (apache#329) Signed-off-by: Reid Chan <[email protected]> Signed-off-by: Michael Stack <[email protected]>

HBASE-22617 Recovered WAL directories not getting cleaned up (apache#330

cef3727

) Signed-off-by: Guanghao Zhang <[email protected]> Signed-off-by: Andrew Purtell <[email protected]>

HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure …

f9da07f

…should skip store files for unknown column families (apache#344) Signed-off-by: Guanghao Zhang <[email protected]>

HBASE-22595 Changed suppressions to full qualified class name

0c0b3a1

Signed-off-by: stack <[email protected]>

HBASE-22633 remove redundant substring call with append for ZKReplica…

402e664

…tionQueueStorage Signed-off-by: Sakthi <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM…

f56bd6c

…'s pendingAssginQueue is cleared

HBASE-22169 Open region failed cause memory leak

988c681

Signed-off-by: stack <[email protected]>

Apache9 and others added 6 commits July 3, 2019 15:08

HBASE-22477 Throwing exception when meta region is not in OPEN state …

faf229b

…in client registry may crash a master

HBASE-21751 WAL creation fails during region open may cause region as…

f5a4cd0

…sign forever fail Signed-off-by: Allan Yang <[email protected]> Signed-off-by: Michael Stack <[email protected]>

HBASE-22637 fix flaky test in TestMetaTableMetrics

fb02877

Signed-off-by: Peter Somogyi <[email protected]> Signed-off-by: Sakthi <[email protected]>

HBASE-13798 TestFromClientSide* don't close the Table

765fe9e

HBASE-22652 Flakey TestLockManager; test timed out after 780 seconds

a001e00

Signed-off-by: Sean Busbey <[email protected]>

HBASE-22604 fix the link in the docs to "Understanding HBase and BigT…

4109c13

…able" by Jim R. Wilson Signed-off-by: Sean Busbey <[email protected]>

Merge branch 'branch-2.1' into HBASE-22537

1b26f7e

wchevreuil closed this Jul 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBase 22537 #307

HBase 22537 #307

Uh oh!

wchevreuil commented Jun 14, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jul 2, 2019

Uh oh!

Apache-HBase commented Jul 2, 2019

Uh oh!

Apache-HBase commented Jul 3, 2019

Uh oh!

wchevreuil commented Jul 3, 2019

Uh oh!

Apache-HBase commented Jul 3, 2019

Uh oh!

Apache-HBase commented Jul 3, 2019

Uh oh!

Apache-HBase commented Jul 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

HBase 22537 #307

HBase 22537 #307

Uh oh!

Conversation

wchevreuil commented Jun 14, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jul 2, 2019

Uh oh!

Apache-HBase commented Jul 2, 2019

Uh oh!

Apache-HBase commented Jul 3, 2019

Uh oh!

wchevreuil commented Jul 3, 2019

Uh oh!

Apache-HBase commented Jul 3, 2019

Uh oh!

Apache-HBase commented Jul 3, 2019

Uh oh!

Apache-HBase commented Jul 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants