HBASE-25586 Fix HBASE-22492 on branch-2 (SASL GapToken) #2961

meszibalu · 2021-02-18T10:31:43Z

ServerCall.java: calling wrapWithSasl() was moved to getResponse(), so
the SASL wrapping is delayed until the reply is sent back to the client.

ServerCall.java: calling wrapWithSasl() was moved to getResponse(), so the SASL wrapping is delayed until the reply is sent back to the client.

Apache-HBase · 2021-02-18T11:09:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 26s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	7m 12s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 10s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	6m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	7m 56s	hbase-server in the patch failed.
		36m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2961
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bf75279855b7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1beda0d`
Default Java	AdoptOpenJDK-11.0.6+10
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/testReport/
Max. process+thread count	748 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-18T11:17:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	3m 9s	master passed
+1 💚	checkstyle	1m 5s	master passed
+1 💚	spotbugs	2m 2s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	compile	3m 10s	the patch passed
+1 💚	javac	3m 10s	the patch passed
+1 💚	checkstyle	1m 1s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 20s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		45m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2961
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux c20dfa560ad3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1beda0d`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

busbey · 2021-02-18T13:07:20Z

Excellent find! Can the reproduction code be used to add a test?

Apache-HBase · 2021-02-18T13:22:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 51s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	shadedjars	6m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	6m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	143m 53s	hbase-server in the patch passed.
		170m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2961
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 86565c5f0d8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1beda0d`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/testReport/
Max. process+thread count	4639 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

meszibalu · 2021-02-18T18:41:36Z

Excellent find! Can the reproduction code be used to add a test?

It would be very problematic, because:

We need a working SASL for it which requires a kerberos at least.
This is a concurrency issue, so the test might consume a lot of resources and might not reproduce the issue.

meszibalu · 2021-02-24T12:24:47Z

retest

joshelser · 2021-02-24T17:41:45Z

It would be very problematic, because:

What about just the code you have used to reproduce this, provided "as-is"? Having been here before, I can understand how tough it is to just get to this problem.

petersomogyi

lgtm

Apache-HBase · 2021-02-25T12:45:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 51s	master passed
+1 💚	compile	3m 8s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	spotbugs	2m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	3m 6s	the patch passed
+1 💚	javac	3m 6s	the patch passed
+1 💚	checkstyle	1m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 15s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		46m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2961
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 818cbb7c25c8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed2693f`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-25T14:42:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 12s	master passed
+1 💚	compile	1m 8s	master passed
+1 💚	shadedjars	6m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 4s	the patch passed
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	134m 52s	hbase-server in the patch passed.
		162m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2961
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5bd8f8109150 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed2693f`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/testReport/
Max. process+thread count	4015 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-25T16:00:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 10s	master passed
+1 💚	compile	1m 0s	master passed
+1 💚	shadedjars	7m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	7m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	212m 17s	hbase-server in the patch passed.
		240m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2961
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 98c3adfaf418 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed2693f`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/testReport/
Max. process+thread count	3389 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2961/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ServerCall.java: calling wrapWithSasl() was moved to getResponse(), so the SASL wrapping is delayed until the reply is sent back to the client. Signed-off-by: Peter Somogyi <[email protected]>

joshelser · 2021-02-26T17:47:27Z

What about just the code you have used to reproduce this, provided "as-is"? Having been here before, I can understand how tough it is to just get to this problem.

Just noticed that the test runner is attached to https://issues.apache.org/jira/browse/HBASE-25586

ServerCall.java: calling wrapWithSasl() was moved to getResponse(), so the SASL wrapping is delayed until the reply is sent back to the client. Signed-off-by: Peter Somogyi <[email protected]> (cherry picked from commit ec9995c) Change-Id: Ibcd471082e617a0d2fda7f4dcbf395cd8022189c

HBASE-25586 Fix HBASE-22492 on branch-2 (SASL GapToken)

54e622b

ServerCall.java: calling wrapWithSasl() was moved to getResponse(), so the SASL wrapping is delayed until the reply is sent back to the client.

petersomogyi approved these changes Feb 25, 2021

View reviewed changes

meszibalu merged commit a984358 into apache:master Feb 26, 2021

meszibalu deleted the my/hbase-25541 branch February 26, 2021 13:06

HBASE-25586 Fix HBASE-22492 on branch-2 (SASL GapToken) #2961

HBASE-25586 Fix HBASE-22492 on branch-2 (SASL GapToken) #2961

Uh oh!

Conversation

meszibalu commented Feb 18, 2021

Uh oh!

Apache-HBase commented Feb 18, 2021

Uh oh!

Apache-HBase commented Feb 18, 2021

Uh oh!

busbey commented Feb 18, 2021

Uh oh!

Apache-HBase commented Feb 18, 2021

Uh oh!

meszibalu commented Feb 18, 2021

Uh oh!

meszibalu commented Feb 24, 2021

Uh oh!

joshelser commented Feb 24, 2021

Uh oh!

petersomogyi left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Feb 25, 2021

Uh oh!

Apache-HBase commented Feb 25, 2021

Uh oh!

Apache-HBase commented Feb 25, 2021

Uh oh!

joshelser commented Feb 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants