Skip to content

HBASE-23887 Bug fix heavyEvictionMbSizeLimit (AdaptiveLRU cache) #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
virajjasani merged 4 commits into from
Feb 15, 2021
Merged

HBASE-23887 Bug fix heavyEvictionMbSizeLimit (AdaptiveLRU cache) #2957

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2544bc1
bug fix heavyEvictionMbSizeLimit
pustota2009 Feb 14, 2021
7ffac64
fix javadoc
pustota2009 Feb 14, 2021
1ec7fc9
Update LruAdaptiveBlockCache.java
pustota2009 Feb 14, 2021
aeb8149
Update LruAdaptiveBlockCache.java
pustota2009 Feb 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,12 @@ public LruAdaptiveBlockCache(long maxSize, long blockSize, Configuration conf) {
* @param singleFactor percentage of total size for single-access blocks
* @param multiFactor percentage of total size for multiple-access blocks
* @param memoryFactor percentage of total size for in-memory blocks
* @param hardLimitFactor hard capacity limit
* @param forceInMemory in-memory hfile's data block has higher priority when evicting
* @param maxBlockSize maximum block size for caching
* @param heavyEvictionCountLimit when starts AdaptiveLRU algoritm work
* @param heavyEvictionMbSizeLimit how many bytes desirable putting into BlockCache
* @param heavyEvictionOverheadCoefficient how aggressive AdaptiveLRU will reduce GC
*/
public LruAdaptiveBlockCache(long maxSize, long blockSize, boolean evictionThread,
int mapInitialSize, float mapLoadFactor, int mapConcurrencyLevel,
Expand Down Expand Up @@ -434,7 +440,7 @@ public LruAdaptiveBlockCache(long maxSize, long blockSize, boolean evictionThrea

// check the bounds
this.heavyEvictionCountLimit = Math.max(heavyEvictionCountLimit, 0);
this.heavyEvictionMbSizeLimit = Math.max(heavyEvictionCountLimit, 1);
this.heavyEvictionMbSizeLimit = Math.max(heavyEvictionMbSizeLimit, 1);
this.cacheDataBlockPercent = 100;
heavyEvictionOverheadCoefficient = Math.min(heavyEvictionOverheadCoefficient, 1.0f);
heavyEvictionOverheadCoefficient = Math.max(heavyEvictionOverheadCoefficient, 0.001f);
Expand Down