HBASE-25445: Use WAL FS instead of master FS in SplitWALManager #2844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dasanjan1296
commented
Jan 5, 2021
dasanjan1296
commented
- If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem instances, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance.
ramkrish86
approved these changes
Jan 5, 2021
Contributor
ramkrish86
left a comment
ramkrish86
left a comment
There was a problem hiding this comment.
Any test case to capture this regression? Else LGTM.
Contributor
Author
|
@ramkrish86 I have added some testing details in the corresponding JIRA for reproducing the error. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jan 5, 2021
Contributor
There was a problem hiding this comment.
Please add a UT at TestSplitWALManager for this condition, as already suggested by @ramkrish86 . This is a simple, yet an important fix, we should safeguard SplitWALManager from inadvertent changes that could suppress this fix.
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Jan 7, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Nice test, just a couple of nits
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
Outdated
Show resolved
Hide resolved
…me local variables
dasanjan1296
force-pushed
the
HBASE-25445
branch
from
73e53f7 to
59ca6d1
Compare
virajjasani
approved these changes
Jan 7, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
+1, Thanks @dasanjan1296
Contributor
|
Once QA results are in, will merge this PR. |
Contributor
|
I think there seems some problem with Jenkins, the recent build is aborted and I am not able to schedule a new build. |
Contributor
|
New build is triggered |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Build is taking more time. Let me merge this PR, I have validated test locally and we also have result available here https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/testReport/org.apache.hadoop.hbase.master/TestSplitWALManager/ |
virajjasani
pushed a commit
that referenced
this pull request
Jan 7, 2021
Signed-off-by: Pankaj <[email protected]> Signed-off-by: ramkrish86 <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jan 7, 2021
Signed-off-by: Pankaj <[email protected]> Signed-off-by: ramkrish86 <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jan 7, 2021
Signed-off-by: Pankaj <[email protected]> Signed-off-by: ramkrish86 <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Jan 7, 2021
Signed-off-by: Pankaj <[email protected]> Signed-off-by: ramkrish86 <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jan 7, 2021
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
I had some nits regarding the current UT, but since this got merged already, we may follow on another jira.
|
|
||
| @Test | ||
| public void testWALArchiveWithDifferentWalAndRootFS() throws Exception{ | ||
| HBaseTestingUtility test_util_2 = new HBaseTestingUtility(); |
Contributor
There was a problem hiding this comment.
nit: non static variables should follow camel case style.
| } | ||
| executor.submitProcedure(splitProcedure); | ||
| LOG.info("Submitted SplitProcedure."); | ||
| test_util_2.waitFor(30000, () -> executor.getProcedures().stream() |
Contributor
There was a problem hiding this comment.
Shouldn't we filter by the split procedure submitted and assert it has completed success?
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…he#2844) Signed-off-by: Pankaj <[email protected]> Signed-off-by: ramkrish86 <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit cb720e0) Change-Id: I5a1f7bf4ce1bcfcd7e3534f4e7d516869df304dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.