Skip to content

HBASE-25371: When openRegion fails during initial verification(before… #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saintstack merged 2 commits into from
Dec 21, 2020
Merged

HBASE-25371: When openRegion fails during initial verification(before… #2785

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f57555
HBASE-25371: When openRegion fails during initial verification(before…
arshadmohammad Dec 17, 2020
449cbda
Removed test case, added code comment
arshadmohammad Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8135,7 +8135,7 @@ protected HRegion openHRegion(final CancelableProgressable reporter)
// MetricsRegionWrapperImpl is already init and not close,
// add region close when open failed
try {
this.close();
this.close(true);
} catch (Throwable e) {
LOG.warn("Open region: {} failed. Try close region but got exception ", this.getRegionInfo(),
e);
Expand Down
36 changes: 36 additions & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.hadoop.hbase.regionserver;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.io.IOException;
Expand All @@ -34,8 +35,10 @@
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
import org.apache.hadoop.hbase.client.Connection;
import org.apache.hadoop.hbase.client.ConnectionFactory;
import org.apache.hadoop.hbase.client.Put;
import org.apache.hadoop.hbase.client.RegionInfo;
import org.apache.hadoop.hbase.client.RegionInfoBuilder;
import org.apache.hadoop.hbase.client.Table;
import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
import org.apache.hadoop.hbase.executor.ExecutorType;
Expand All @@ -46,6 +49,7 @@
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
Expand Down Expand Up @@ -135,4 +139,36 @@ public void testNonExistentRegionReplica() throws Exception {
}
fail("Should have thrown IOE when attempting to open a non-existing region.");
}

/*
* Before applying the fix run this test case, error message
* "java.io.IOException: The new max sequence id 1 is less than the old max sequence id 17"
* can be found the log.
* After applying the fix run this test case above message should not be logged.
*/
//@Test(timeout = 60000)
@Ignore
public void testRegionOpenFailure() throws Exception {
final TableName tableName = TableName.valueOf(name.getMethodName());
final byte[] FAMILY = Bytes.toBytes("fq");
Admin admin = HTU.getAdmin();
admin.createTable(TableDescriptorBuilder.newBuilder(tableName)
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(FAMILY)).build());
assertTrue("Table creation was not success", admin.tableExists(tableName));

// Put some records to increase the read sequence id
final Table table = HTU.getConnection().getTable(tableName);
for (int i = 0; i < 10; i++) {
Put put = new Put(Bytes.toBytes("row" + i));
put.addColumn(FAMILY, Bytes.toBytes("q1"), Bytes.toBytes("value" + i));
table.put(put);
}
admin.flush(tableName);

TableDescriptorBuilder.newBuilder(table.getDescriptor());
final ColumnFamilyDescriptorBuilder newFamilyDesc =
ColumnFamilyDescriptorBuilder.newBuilder(table.getDescriptor().getColumnFamily(FAMILY));
newFamilyDesc.setEncryptionType("InvalidEncryptionType");
admin.modifyColumnFamily(tableName, newFamilyDesc.build());
}
}