Skip to content

HBASE-25292 [branch-2] Improve InetSocketAddress usage discipline #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apurtell wants to merge 4 commits into from
Closed

HBASE-25292 [branch-2] Improve InetSocketAddress usage discipline #2670

apurtell wants to merge 4 commits into from

Conversation

@apurtell
Copy link
Contributor

@apurtell apurtell commented Nov 17, 2020

See description on #2669

@apurtell apurtell changed the title HBASE-25292 Improve InetSocketAddress usage discipline HBASE-25292 [branch-2] Improve InetSocketAddress usage discipline Nov 17, 2020
@Apache-HBase
Copy link

Apache-HBase commented Nov 17, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 32s branch-2 passed
+1 💚 checkstyle 2m 27s branch-2 passed
+1 💚 spotbugs 4m 43s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 11s the patch passed
-0 ⚠️ checkstyle 0m 33s hbase-client: The patch generated 3 new + 18 unchanged - 1 fixed = 21 total (was 19)
-0 ⚠️ checkstyle 1m 7s hbase-server: The patch generated 1 new + 51 unchanged - 0 fixed = 52 total (was 51)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 30s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 5m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
48m 10s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2670
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux c74df4e2bb6b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / e8ecf2e
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 18, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 7m 48s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 46s branch-2 passed
+1 💚 compile 2m 47s branch-2 passed
+1 💚 shadedjars 7m 26s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 5s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 24s the patch passed
+1 💚 compile 2m 46s the patch passed
+1 💚 javac 2m 46s the patch passed
+1 💚 shadedjars 7m 27s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 8s the patch passed
_ Other Tests _
+1 💚 unit 1m 50s hbase-common in the patch passed.
+1 💚 unit 2m 38s hbase-client in the patch passed.
+1 💚 unit 0m 44s hbase-zookeeper in the patch passed.
+1 💚 unit 194m 7s hbase-server in the patch passed.
+1 💚 unit 0m 37s hbase-external-blockcache in the patch passed.
244m 51s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux 24ebb8ae26a9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / e8ecf2e
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/testReport/
Max. process+thread count 2453 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 18, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 7m 27s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2 passed
+1 💚 compile 2m 18s branch-2 passed
+1 💚 shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 48s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 37s the patch passed
+1 💚 compile 2m 20s the patch passed
+1 💚 javac 2m 20s the patch passed
+1 💚 shadedjars 6m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 46s the patch passed
_ Other Tests _
+1 💚 unit 1m 32s hbase-common in the patch passed.
+1 💚 unit 2m 28s hbase-client in the patch passed.
+1 💚 unit 0m 41s hbase-zookeeper in the patch passed.
+1 💚 unit 207m 26s hbase-server in the patch passed.
+1 💚 unit 0m 33s hbase-external-blockcache in the patch passed.
252m 0s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux 92ce573fd645 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / e8ecf2e
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/testReport/
Max. process+thread count 2734 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell force-pushed the HBASE-25292-branch-2 branch 2 times, most recently from e2a0926 to 6824b0c Compare November 18, 2020 22:20
@Apache-HBase
Copy link

Apache-HBase commented Nov 18, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 3m 34s branch-2 passed
+1 💚 checkstyle 2m 29s branch-2 passed
+1 💚 spotbugs 4m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 14s the patch passed
-0 ⚠️ checkstyle 0m 33s hbase-client: The patch generated 7 new + 18 unchanged - 1 fixed = 25 total (was 19)
-0 ⚠️ checkstyle 1m 8s hbase-server: The patch generated 1 new + 51 unchanged - 0 fixed = 52 total (was 51)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 41s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 5m 25s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
43m 55s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2670
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 39d2a4ef3a7a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4d41de1
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 19, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 9s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 21s branch-2 passed
+1 💚 compile 2m 50s branch-2 passed
+1 💚 shadedjars 6m 58s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 7s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 2m 43s the patch passed
+1 💚 javac 2m 43s the patch passed
+1 💚 shadedjars 6m 45s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 4s the patch passed
_ Other Tests _
+1 💚 unit 1m 48s hbase-common in the patch passed.
+1 💚 unit 2m 29s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 129m 55s hbase-server in the patch passed.
+1 💚 unit 0m 43s hbase-external-blockcache in the patch passed.
171m 43s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux fd0c7aa8fe8a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4d41de1
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/testReport/
Max. process+thread count 4467 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 19, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2 passed
+1 💚 compile 2m 21s branch-2 passed
+1 💚 shadedjars 6m 33s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 50s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 41s the patch passed
+1 💚 compile 2m 20s the patch passed
+1 💚 javac 2m 20s the patch passed
+1 💚 shadedjars 6m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 47s the patch passed
_ Other Tests _
+1 💚 unit 1m 33s hbase-common in the patch passed.
+1 💚 unit 2m 27s hbase-client in the patch passed.
+1 💚 unit 0m 41s hbase-zookeeper in the patch passed.
+1 💚 unit 205m 42s hbase-server in the patch passed.
+1 💚 unit 0m 34s hbase-external-blockcache in the patch passed.
243m 57s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux e7978e5ceaf3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4d41de1
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/testReport/
Max. process+thread count 2444 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 19, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 mvninstall 3m 28s branch-2 passed
+1 💚 checkstyle 2m 19s branch-2 passed
+1 💚 spotbugs 4m 56s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 20s the patch passed
-0 ⚠️ checkstyle 0m 29s hbase-client: The patch generated 7 new + 18 unchanged - 1 fixed = 25 total (was 19)
-0 ⚠️ checkstyle 1m 4s hbase-server: The patch generated 1 new + 54 unchanged - 0 fixed = 55 total (was 54)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 21s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 6m 33s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
48m 29s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2670
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 61952f9cf5f4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fdff8ef
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 95 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 19, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 31s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 35s branch-2 passed
+1 💚 compile 2m 23s branch-2 passed
+1 💚 shadedjars 5m 56s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 56s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 15s the patch passed
+1 💚 compile 2m 24s the patch passed
+1 💚 javac 2m 24s the patch passed
+1 💚 shadedjars 6m 2s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 55s the patch passed
_ Other Tests _
+1 💚 unit 1m 34s hbase-common in the patch passed.
+1 💚 unit 2m 20s hbase-client in the patch passed.
+1 💚 unit 0m 42s hbase-zookeeper in the patch passed.
-1 ❌ unit 140m 45s hbase-server in the patch failed.
+1 💚 unit 0m 36s hbase-external-blockcache in the patch passed.
178m 49s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux a075b8d443d7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fdff8ef
Default Java AdoptOpenJDK-1.8.0_232-b09
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/testReport/
Max. process+thread count 4307 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 19, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 30s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 46s Maven dependency ordering for branch
+1 💚 mvninstall 4m 39s branch-2 passed
+1 💚 compile 2m 48s branch-2 passed
+1 💚 shadedjars 7m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 5s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 40s the patch passed
+1 💚 compile 2m 48s the patch passed
+1 💚 javac 2m 49s the patch passed
+1 💚 shadedjars 8m 2s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 13s the patch passed
_ Other Tests _
+1 💚 unit 1m 50s hbase-common in the patch passed.
+1 💚 unit 2m 57s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
-1 ❌ unit 209m 5s hbase-server in the patch failed.
+1 💚 unit 0m 31s hbase-external-blockcache in the patch passed.
255m 13s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux 46fd0deb1e96 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fdff8ef
Default Java AdoptOpenJDK-11.0.6+10
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/testReport/
Max. process+thread count 2401 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell force-pushed the HBASE-25292-branch-2 branch from f7eec92 to e2daa5c Compare November 20, 2020 02:52
@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 4m 37s branch-2 passed
+1 💚 checkstyle 2m 46s branch-2 passed
+1 💚 spotbugs 5m 27s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 14s the patch passed
-0 ⚠️ checkstyle 0m 41s hbase-client: The patch generated 7 new + 18 unchanged - 1 fixed = 25 total (was 19)
-0 ⚠️ checkstyle 1m 24s hbase-server: The patch generated 1 new + 54 unchanged - 0 fixed = 55 total (was 54)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 16m 9s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 7m 1s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 13s The patch does not generate ASF License warnings.
56m 31s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2670
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 6aa2737f70e2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bace137
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 95 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 9s branch-2 passed
+1 💚 compile 2m 42s branch-2 passed
+1 💚 shadedjars 6m 43s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 9s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 53s the patch passed
+1 💚 compile 2m 39s the patch passed
+1 💚 javac 2m 39s the patch passed
+1 💚 shadedjars 6m 40s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 8s the patch passed
_ Other Tests _
+1 💚 unit 1m 48s hbase-common in the patch passed.
+1 💚 unit 2m 28s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
-1 ❌ unit 131m 49s hbase-server in the patch failed.
+1 💚 unit 0m 37s hbase-external-blockcache in the patch passed.
173m 4s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3292cb272a31 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bace137
Default Java AdoptOpenJDK-11.0.6+10
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/testReport/
Max. process+thread count 4242 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 14s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 3m 45s branch-2 passed
+1 💚 compile 2m 24s branch-2 passed
+1 💚 shadedjars 6m 32s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 48s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 36s the patch passed
+1 💚 compile 2m 20s the patch passed
+1 💚 javac 2m 20s the patch passed
+1 💚 shadedjars 6m 30s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 48s the patch passed
_ Other Tests _
+1 💚 unit 1m 31s hbase-common in the patch passed.
+1 💚 unit 2m 29s hbase-client in the patch passed.
+1 💚 unit 0m 40s hbase-zookeeper in the patch passed.
-1 ❌ unit 204m 58s hbase-server in the patch failed.
+1 💚 unit 0m 29s hbase-external-blockcache in the patch passed.
243m 29s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9903d5957296 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bace137
Default Java AdoptOpenJDK-1.8.0_232-b09
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/testReport/
Max. process+thread count 2774 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell force-pushed the HBASE-25292-branch-2 branch from 0221713 to 01e4731 Compare November 20, 2020 22:08
@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 54s branch-2 passed
+1 💚 checkstyle 2m 36s branch-2 passed
+1 💚 spotbugs 4m 52s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 32s the patch passed
-0 ⚠️ checkstyle 0m 36s hbase-client: The patch generated 7 new + 18 unchanged - 1 fixed = 25 total (was 19)
-0 ⚠️ checkstyle 1m 15s hbase-server: The patch generated 1 new + 54 unchanged - 0 fixed = 55 total (was 54)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 54s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 5m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
47m 13s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2670
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux f4ab7e0b25c4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bace137
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 21, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 35s branch-2 passed
+1 💚 compile 2m 27s branch-2 passed
+1 💚 shadedjars 5m 58s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 54s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 15s the patch passed
+1 💚 compile 2m 26s the patch passed
+1 💚 javac 2m 26s the patch passed
+1 💚 shadedjars 5m 59s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 53s the patch passed
_ Other Tests _
+1 💚 unit 1m 33s hbase-common in the patch passed.
+1 💚 unit 2m 14s hbase-client in the patch passed.
+1 💚 unit 0m 41s hbase-zookeeper in the patch passed.
+1 💚 unit 142m 41s hbase-server in the patch passed.
+1 💚 unit 0m 43s hbase-external-blockcache in the patch passed.
179m 28s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux 341431aa86bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bace137
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/testReport/
Max. process+thread count 4016 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 21, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 4m 2s branch-2 passed
+1 💚 compile 2m 41s branch-2 passed
+1 💚 shadedjars 6m 43s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 8s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 55s the patch passed
+1 💚 compile 2m 40s the patch passed
+1 💚 javac 2m 40s the patch passed
+1 💚 shadedjars 6m 42s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 8s the patch passed
_ Other Tests _
+1 💚 unit 1m 51s hbase-common in the patch passed.
+1 💚 unit 2m 24s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 139m 40s hbase-server in the patch passed.
+1 💚 unit 0m 41s hbase-external-blockcache in the patch passed.
180m 23s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux 69bd6e07333c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / bace137
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/testReport/
Max. process+thread count 4611 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 21, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 7s #2670 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #2670
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/6/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

1 similar comment
@Apache-HBase
Copy link

Apache-HBase commented Nov 21, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 7s #2670 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #2670
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/6/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 21, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 6s #2670 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #2670
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/6/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell and others added 4 commits November 25, 2020 14:42
@apurtell
HBASE-25292 Improve InetSocketAddress usage discipline
64fbb5b 
Network identities should be bound late. Remote addresses should be
resolved at the last possible moment, just before connect(). Network
identity mappings can change, so our code should not inappropriately
cache them. Otherwise we might miss a change and fail to operate normally.

Revert "HBASE-14544 Allow HConnectionImpl to not refresh the dns on errors"
Removes hbase.resolve.hostnames.on.failure and related code. We always
resolve hostnames, as late as possible.

Preserve InetSocketAddress caching per RPC connection. Avoids potential
lookups per Call.

Replace InetSocketAddress with Address where used as a map key. If we want
to key by hostname and/or resolved address we should be explicit about it.
Using Address chooses mapping by hostname and port only.

Add metrics for potential nameservice resolution attempts, whenever an
InetSocketAddress is instantiated for connect; and metrics for failed
resolution, whenever InetSocketAddress#isUnresolved on the new instance
is true.
@apurtell
Use ServerName directly to build a stub key
8b811b8
Resolve and cache ISA on a RpcChannel as late as possible, at first call
e689ef2
Remove now invalid unit test TestCIBadHostname
165235d 
We resolve DNS at the latest possible time, at first call, and do not
resolve hostnames for creating stubs at all, so this unit test cannot
work now.
@apurtell apurtell force-pushed the HBASE-25292-branch-2 branch from 01e4731 to 165235d Compare November 25, 2020 22:46
@Apache-HBase
Copy link

Apache-HBase commented Nov 25, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 19s branch-2 passed
+1 💚 checkstyle 2m 47s branch-2 passed
+1 💚 spotbugs 5m 33s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 47s the patch passed
-0 ⚠️ checkstyle 0m 34s hbase-client: The patch generated 7 new + 23 unchanged - 1 fixed = 30 total (was 24)
-0 ⚠️ checkstyle 1m 17s hbase-server: The patch generated 1 new + 54 unchanged - 0 fixed = 55 total (was 54)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 14m 9s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 7m 4s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 4s The patch does not generate ASF License warnings.
55m 56s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2670
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux a398ca805c3b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1b6399a
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 95 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/7/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 26, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 50s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 24s branch-2 passed
+1 💚 compile 2m 44s branch-2 passed
+1 💚 shadedjars 6m 50s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 10s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 4m 0s the patch passed
+1 💚 compile 2m 43s the patch passed
+1 💚 javac 2m 43s the patch passed
+1 💚 shadedjars 6m 44s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 6s the patch passed
_ Other Tests _
+1 💚 unit 1m 51s hbase-common in the patch passed.
+1 💚 unit 2m 37s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 133m 47s hbase-server in the patch passed.
+1 💚 unit 0m 45s hbase-external-blockcache in the patch passed.
178m 56s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2670
Optional Tests javac javadoc unit shadedjars compile
uname Linux c80a8456ca34 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 1b6399a
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/7/testReport/
Max. process+thread count 4335 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2670/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

apurtell commented Dec 4, 2020

#2669 was merged, closing this and picking back the master commit.

@apurtell apurtell closed this Dec 4, 2020
@apurtell apurtell deleted the HBASE-25292-branch-2 branch December 4, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apurtell @Apache-HBase