HBASE-18095 branch-1 umbrella PR #2280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
36ea9e2 to
10eaec5
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
3 times, most recently
from
f81932c to
a70e088
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
a70e088 to
6d71600
Compare
Contributor
Author
|
Back ported until the commit that implements all the server side RPCs needed by the registry. The build is clean so far. Next step is to back port the registry changes. I might have to reimplement it given all the client side incompatibilities. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
cd629de to
612689a
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
2 times, most recently
from
5955740 to
47e361b
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
47e361b to
428e38e
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
428e38e to
4d9427e
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
commented
Sep 2, 2020
Contributor
Author
There was a problem hiding this comment.
Test run is clean (except for check-style import order issues). Last change decoupled the TableState dependency from Zookeeper. That was critical to decoupling ZK from client. This was already done in master/branch-2 by the time HBASE-18095 was implemented. Had to to cherry-pick the relevant fix to branch-1. There were many conflicts but overall tests seem to be stable. Will now switch to implementing master registry fixes.
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
4d9427e to
17bb951
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
17bb951 to
98679e7
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
98679e7 to
1f6ec87
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
1f6ec87 to
37ea4c6
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
d87d716 to
d330886
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
d330886 to
1501a93
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
1501a93 to
583e127
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
583e127 to
55cf7ea
Compare
bharathv
changed the title
|
💔 -1 overall
This message was automatically generated. |
apurtell
approved these changes
Sep 11, 2020
Contributor
apurtell
left a comment
apurtell
left a comment
There was a problem hiding this comment.
Compact checker of this change compared to branch-1 HEAD flags only acceptable changes (method additions) and one method removed from ZkCoordinatedStateManager, but this is LimitedPrivate(CONFIG) so that's fine.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Show resolved
Hide resolved
bharathv
commented
Sep 14, 2020
Contributor
Author
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
Thanks for the review. Not pushing a new patch version yet, will do once I hear back on the comments.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
Outdated
Show resolved
Hide resolved
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
2 times, most recently
from
8f4af6e to
d907127
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This patch implements a simple cache that all the masters can lookup to serve cluster ID to clients. Active HMaster is still responsible for creating it but all the masters will read it from fs to serve clients. RPCs exposing it will come in a separate patch as a part of HBASE-18095. Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit c2e01f2) (cherry picked from commit 9ab6529)
…ache#812) Currently we just track whether an active master exists. It helps to also track the address of the active master in all the masters to help serve the client RPC requests to know which master is active. Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Andrew Purtell <[email protected]> (cherry picked from commit efebb84) (cherry picked from commit 7429491)
* HBASE-23281: Track meta region changes on masters This patch adds a simple cache that tracks the meta region replica locations. It keeps an eye on the region movements so that the cached locations are not stale. This information is used for servicing client RPCs for connections that use master based registry (HBASE-18095). The RPC end points will be added in a separate patch. Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 8571d38) (cherry picked from commit 89581d9)
* HBASE-23304: RPCs needed for client meta information lookup This patch implements the RPCs needed for the meta information lookup during connection init. New tests added to cover the RPC code paths. HBASE-23305 builds on this to implement the client side logic. Fixed a bunch of checkstyle nits around the places the patch touches. Signed-off-by: Andrew Purtell <[email protected]> (cherry picked from commit 4f8fbba) (cherry picked from commit 488460e)
…Andrey Stepachev) (cherry picked from commit 3cc5d19)
This patch adds the ability to discover newly added masters dynamically on the master registry side. The trigger for the re-fetch is either periodic (5 mins) or any registry RPC failure. Master server information is cached in masters to avoid repeated ZK lookups. Updates the client side connection metrics to maintain a counter per RPC type so that clients have visibility into counts grouped by RPC method name. I didn't add the method to ZK registry interface since there is a design discussion going on in splittable meta doc. We can add it later if needed. Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 275a38e) (cherry picked from commit bb9121d)
bharathv
force-pushed
the
HBASE-18085-branch-1
branch
from
d907127 to
de553a4
Compare
Contributor
Author
|
Rebased on the latest branch-1 tip. Will merge after the test run later today. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will keep piling on commits on to this PR in the coming days as and when I find time.