Skip to content

HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
virajjasani merged 2 commits into from
Aug 12, 2020
Merged

HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuilder #2214

virajjasani merged 2 commits into from
Aug 12, 2020

Conversation

@virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Aug 7, 2020

Closes #2196

Signed-off-by: Nick Dimiduk [email protected]
Signed-off-by: Ted Yu [email protected]

@virajjasani virajjasani added the backport This PR is a back port of some issue or issues already committed to master label Aug 7, 2020
@Apache-HBase
Copy link

Apache-HBase commented Aug 7, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 36s branch-2 passed
+1 💚 checkstyle 3m 33s branch-2 passed
+1 💚 spotbugs 6m 38s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 9s the patch passed
-0 ⚠️ checkstyle 0m 35s hbase-client: The patch generated 7 new + 95 unchanged - 0 fixed = 102 total (was 95)
-0 ⚠️ checkstyle 0m 13s hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 15s hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 1m 11s hbase-server: The patch generated 25 new + 231 unchanged - 1 fixed = 256 total (was 232)
-0 ⚠️ checkstyle 0m 41s hbase-thrift: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
-0 ⚠️ checkstyle 0m 15s hbase-examples: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 27s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 7m 45s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 28s The patch does not generate ASF License warnings.
51m 7s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2214
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux cb9a54e164f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / cb3dd99
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-examples.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-procedure hbase-server hbase-thrift hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 8, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 3m 10s branch-2 passed
+1 💚 checkstyle 3m 31s branch-2 passed
+1 💚 spotbugs 7m 3s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
-0 ⚠️ checkstyle 0m 35s hbase-client: The patch generated 7 new + 95 unchanged - 0 fixed = 102 total (was 95)
-0 ⚠️ checkstyle 0m 12s hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 15s hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 1m 17s hbase-server: The patch generated 25 new + 231 unchanged - 1 fixed = 256 total (was 232)
-0 ⚠️ checkstyle 0m 40s hbase-thrift: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
-0 ⚠️ checkstyle 0m 14s hbase-examples: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 48s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 8m 27s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 14s The patch does not generate ASF License warnings.
52m 45s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2214
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 58d2338131c6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 11cfb0f
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-examples.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-procedure hbase-server hbase-thrift hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 8, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 22s branch-2 passed
+1 💚 checkstyle 3m 27s branch-2 passed
+1 💚 spotbugs 7m 22s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 53s the patch passed
-0 ⚠️ checkstyle 0m 42s hbase-client: The patch generated 7 new + 95 unchanged - 0 fixed = 102 total (was 95)
-0 ⚠️ checkstyle 0m 14s hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 14s hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 1m 22s hbase-server: The patch generated 25 new + 231 unchanged - 1 fixed = 256 total (was 232)
-0 ⚠️ checkstyle 0m 47s hbase-thrift: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
-0 ⚠️ checkstyle 0m 15s hbase-examples: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 58s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 8m 38s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 21s The patch does not generate ASF License warnings.
57m 18s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2214
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 24b1dedf0532 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4a2f3f8
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-examples.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-procedure hbase-server hbase-thrift hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 9, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 10s branch-2 passed
+1 💚 compile 3m 42s branch-2 passed
+1 💚 shadedjars 5m 50s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 31s hbase-client in branch-2 failed.
-0 ⚠️ javadoc 0m 18s hbase-common in branch-2 failed.
-0 ⚠️ javadoc 0m 23s hbase-examples in branch-2 failed.
-0 ⚠️ javadoc 0m 18s hbase-procedure in branch-2 failed.
-0 ⚠️ javadoc 0m 40s hbase-server in branch-2 failed.
-0 ⚠️ javadoc 0m 48s hbase-thrift in branch-2 failed.
-0 ⚠️ javadoc 0m 17s hbase-zookeeper in branch-2 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 3m 44s the patch passed
+1 💚 javac 3m 44s the patch passed
+1 💚 shadedjars 5m 51s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 28s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 17s hbase-zookeeper in the patch failed.
-0 ⚠️ javadoc 0m 18s hbase-procedure in the patch failed.
-0 ⚠️ javadoc 0m 41s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 49s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 21s hbase-examples in the patch failed.
_ Other Tests _
+1 💚 unit 1m 40s hbase-common in the patch passed.
+1 💚 unit 2m 22s hbase-client in the patch passed.
+1 💚 unit 0m 44s hbase-zookeeper in the patch passed.
+1 💚 unit 1m 37s hbase-procedure in the patch passed.
-1 ❌ unit 508m 11s hbase-server in the patch failed.
+1 💚 unit 5m 9s hbase-thrift in the patch passed.
+1 💚 unit 1m 37s hbase-examples in the patch passed.
777m 50s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2214
Optional Tests javac javadoc unit shadedjars compile
uname Linux b0ec1d330c95 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4a2f3f8
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/testReport/
Max. process+thread count 3237 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-procedure hbase-server hbase-thrift hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani mentioned this pull request Aug 11, 2020
Closed
@Apache-HBase
Copy link

Apache-HBase commented Aug 11, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s branch-2 passed
+1 💚 checkstyle 3m 39s branch-2 passed
+1 💚 spotbugs 6m 50s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 29s the patch passed
-0 ⚠️ checkstyle 0m 23s hbase-common: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
-0 ⚠️ checkstyle 0m 36s hbase-client: The patch generated 7 new + 95 unchanged - 0 fixed = 102 total (was 95)
-0 ⚠️ checkstyle 0m 11s hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 13s hbase-procedure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 1m 17s hbase-server: The patch generated 24 new + 231 unchanged - 1 fixed = 255 total (was 232)
-0 ⚠️ checkstyle 0m 46s hbase-thrift: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
-0 ⚠️ checkstyle 0m 12s hbase-examples: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 41s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 8m 0s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 12s The patch does not generate ASF License warnings.
54m 24s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2214
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 04784381231e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7f5f577
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-examples.txt
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-procedure hbase-server hbase-thrift hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 11, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 38s branch-2 passed
+1 💚 compile 3m 22s branch-2 passed
+1 💚 shadedjars 5m 8s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 46s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 11s the patch passed
+1 💚 compile 3m 21s the patch passed
+1 💚 javac 3m 21s the patch passed
+1 💚 shadedjars 5m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 47s the patch passed
_ Other Tests _
+1 💚 unit 1m 20s hbase-common in the patch passed.
+1 💚 unit 2m 17s hbase-client in the patch passed.
+1 💚 unit 0m 45s hbase-zookeeper in the patch passed.
+1 💚 unit 1m 44s hbase-procedure in the patch passed.
+1 💚 unit 135m 19s hbase-server in the patch passed.
+1 💚 unit 4m 0s hbase-thrift in the patch passed.
+1 💚 unit 2m 9s hbase-examples in the patch passed.
181m 41s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2214
Optional Tests javac javadoc unit shadedjars compile
uname Linux 448caacf19d8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7f5f577
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/testReport/
Max. process+thread count 4557 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-procedure hbase-server hbase-thrift hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 11, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 4m 57s branch-2 passed
+1 💚 compile 4m 39s branch-2 passed
+1 💚 shadedjars 7m 21s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-common in branch-2 failed.
-0 ⚠️ javadoc 0m 33s hbase-client in branch-2 failed.
-0 ⚠️ javadoc 0m 20s hbase-zookeeper in branch-2 failed.
-0 ⚠️ javadoc 0m 18s hbase-procedure in branch-2 failed.
-0 ⚠️ javadoc 0m 48s hbase-server in branch-2 failed.
-0 ⚠️ javadoc 1m 2s hbase-thrift in branch-2 failed.
-0 ⚠️ javadoc 0m 23s hbase-examples in branch-2 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 4m 52s the patch passed
+1 💚 compile 4m 32s the patch passed
+1 💚 javac 4m 32s the patch passed
+1 💚 shadedjars 7m 24s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-common in the patch failed.
-0 ⚠️ javadoc 0m 33s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 21s hbase-zookeeper in the patch failed.
-0 ⚠️ javadoc 0m 19s hbase-procedure in the patch failed.
-0 ⚠️ javadoc 0m 52s hbase-server in the patch failed.
-0 ⚠️ javadoc 1m 2s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 26s hbase-examples in the patch failed.
_ Other Tests _
+1 💚 unit 1m 50s hbase-common in the patch passed.
+1 💚 unit 2m 33s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 1m 44s hbase-procedure in the patch passed.
-1 ❌ unit 138m 46s hbase-server in the patch failed.
+1 💚 unit 5m 6s hbase-thrift in the patch passed.
+1 💚 unit 2m 6s hbase-examples in the patch passed.
198m 31s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2214
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4ed01102cf42 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 7f5f577
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/testReport/
Max. process+thread count 3895 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-zookeeper hbase-procedure hbase-server hbase-thrift hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2214/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

nyl3532016
nyl3532016 approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@nyl3532016 nyl3532016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani
Copy link
Contributor Author

virajjasani commented Aug 12, 2020

TestRegionServerReportForDuty is passing locally.

@virajjasani virajjasani merged commit 8ccf643 into apache:branch-2 Aug 12, 2020
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@virajjasani @clarax
HBASE-24750 : All ExecutorService should use guava ThreadFactoryBuild…
84e1d5c 
…er (apache#2214)

Closes apache#2196

Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ted Yu <[email protected]>
Signed-off-by: niuyulin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nyl3532016 nyl3532016 nyl3532016 approved these changes

Assignees

No one assigned

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@virajjasani @Apache-HBase @nyl3532016