HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe (branch-1) #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor how we use connection to rely on the access method * refactor initialization and cleanup of the shared connection * incompatibly change HCTU's Configuration member variable to be final so it can be safely accessed from multiple threads. Closes apache#2180 adapted for jdk7 (cherry picked from commit 86ebbdd) (cherry picked from commit 0806349)
virajjasani
reviewed
Aug 3, 2020
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Left a minor nit, +1 otherwise
Comment on lines
3023
to
3030
| if (! this.connection.compareAndSet(null, connection)) { | ||
| try { | ||
| connection.close(); | ||
| } catch (IOException exception) { | ||
| LOG.debug("Ignored failure while closing connection on contended connection creation.", | ||
| exception); | ||
| } | ||
| connection = this.connection.get(); |
Contributor
There was a problem hiding this comment.
This logic is perfect, but for a while I got confused with connection being Connection and this.connection being AtomicReference.
Can we rename connection to connectionRef to indicate AtomicReference?
Contributor
Author
There was a problem hiding this comment.
sure! should I update master and branches-2 to similarly use asyncConnectionRef instead of asyncConnection? Or less confusing there because the instance and local names are already different?
Contributor
There was a problem hiding this comment.
I think branch-2+ seem good because names are different already 👍
busbey
added
the
backport
…to the shared connection.
asfgit
pushed a commit
that referenced
this pull request
Aug 4, 2020
* refactor how we use connection to rely on the access method * refactor initialization and cleanup of the shared connection * incompatibly change HCTU's Configuration member variable to be final so it can be safely accessed from multiple threads. Closes #2188 adapted for jdk7 Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 86ebbdd) (cherry picked from commit 0806349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2180
adapted for jdk7
(cherry picked from commit 86ebbdd)
(cherry picked from commit 0806349)