Skip to content

HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751 #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramkrish86 merged 3 commits into from
Aug 3, 2020
Merged

HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751 #2125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72932ad
null check for writer if not initialized yet during syncrunner run
gkanade Jul 23, 2020
b5da6ce
Revert "null check for writer if not initialized yet during syncrunne…
gkanade Jul 31, 2020
69ec73a
Writer check while trying to attain safe point
gkanade Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ protected void doReplaceWriter(Path oldPath, Path newPath, Writer nextWriter) th
SyncFuture syncFuture = null;
SafePointZigZagLatch zigzagLatch = null;
long sequence = -1L;
if (this.ringBufferEventHandler != null) {
if (this.writer != null && this.ringBufferEventHandler != null) {
// Get sequence first to avoid dead lock when ring buffer is full
// Considering below sequence
// 1. replaceWriter is called and zigzagLatch is initialized
Expand Down