Skip to content

HBASE-24572 release scripts should try to use a keyid when refering to GPG keys. #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busbey merged 2 commits into from
Aug 2, 2020
Merged

HBASE-24572 release scripts should try to use a keyid when refering to GPG keys. #2001

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19d1df6
HBASE-24572 release scripts should try to use a keyid when refering t…
busbey Jun 30, 2020
e4593b8
addendum to fix the GPG KEY ID prompt
busbey Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dev-support/create-release/release-util.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,14 @@ function get_release_info {

GIT_EMAIL="[email protected]"
GPG_KEY="$(read_config "GPG_KEY" "$GIT_EMAIL")"
if ! GPG_KEY_ID=$("${GPG}" "${GPG_ARGS[@]}" --keyid-format 0xshort --list-public-key "${GPG_KEY}" | grep "\[S\]" | grep -o "0x[0-9A-F]*") ||
[ -z "${GPG_KEY_ID}" ] ; then
GPG_KEY_ID=$("${GPG}" "${GPG_ARGS[@]}" --keyid-format 0xshort --list-public-key "${GPG_KEY}" | head -n 1 | grep -o "0x[0-9A-F]*" || true)
fi
read -r -p "We think the key '${GPG_KEY}' corresponds to the key id '${GPG_KEY_ID}'. Is this correct [y/n? " ANSWER
Copy link
Member

@ndimiduk ndimiduk Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing closing brace on [y/n?

if [ "$ANSWER" = "y" ]; then
GPG_KEY="${GPG_KEY_ID}"
fi
export API_DIFF_TAG ASF_USERNAME GIT_NAME GIT_EMAIL GPG_KEY

cat <<EOF
Expand Down