HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal #1535

jojochuang · 2020-04-16T20:37:37Z

Cherrypick the commit to branch-2.3. The cherrypick is clean.

…yncwal (apache#1301) * Use Reflection to access shaded Hadoop protobuf classes. (cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0) * Update to improve the code: 1. Added license. 2. Added more comments. 3. Wrap byte array instead of copy to make a ByteString. 4. Moved all reflection instantiation to static class loading time. * Use LiteralByteString to wrap byte array instead of copying it. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]> (cherry picked from commit 72727ff) (cherry picked from commit ae3de38)

Apache-HBase · 2020-04-16T21:18:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.3 Compile Tests _
+1 💚	mvninstall	3m 52s	branch-2.3 passed
+1 💚	checkstyle	1m 13s	branch-2.3 passed
+1 💚	spotbugs	2m 7s	branch-2.3 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 29s	the patch passed
-0 ⚠️	checkstyle	1m 13s	hbase-server: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 45s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		38m 27s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1535
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 428bc91ecd30 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.3 / `e1dcc7b`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-16T23:03:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.3 Compile Tests _
+1 💚	mvninstall	3m 45s	branch-2.3 passed
+1 💚	compile	0m 55s	branch-2.3 passed
+1 💚	shadedjars	4m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	branch-2.3 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 12s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	121m 9s	hbase-server in the patch passed.
		143m 21s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1535
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ebd9c2d2512f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.3 / `e1dcc7b`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/testReport/
Max. process+thread count	3842 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-16T23:05:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.3 Compile Tests _
+1 💚	mvninstall	4m 2s	branch-2.3 passed
+1 💚	compile	1m 3s	branch-2.3 passed
+1 💚	shadedjars	5m 48s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in branch-2.3 failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 50s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	5m 11s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 38s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	120m 22s	hbase-server in the patch passed.
		145m 22s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1535
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e8cc6519a1dd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.3 / `e1dcc7b`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/testReport/
Max. process+thread count	4010 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…yncwal (apache#1301) (apache#1535) * Use Reflection to access shaded Hadoop protobuf classes. (cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0) * Update to improve the code: 1. Added license. 2. Added more comments. 3. Wrap byte array instead of copy to make a ByteString. 4. Moved all reflection instantiation to static class loading time. * Use LiteralByteString to wrap byte array instead of copying it. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]> (cherry picked from commit 72727ff) (cherry picked from commit ae3de38)

…yncwal (apache#1301) (apache#1535) * Use Reflection to access shaded Hadoop protobuf classes. (cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0) * Update to improve the code: 1. Added license. 2. Added more comments. 3. Wrap byte array instead of copy to make a ByteString. 4. Moved all reflection instantiation to static class loading time. * Use LiteralByteString to wrap byte array instead of copying it. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]> (cherry picked from commit 72727ff) (cherry picked from commit ae3de38) (cherry picked from commit b8b8e0a)

…yncwal (#1301) (#1535) (#1567) * Use Reflection to access shaded Hadoop protobuf classes. (cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0) * Update to improve the code: 1. Added license. 2. Added more comments. 3. Wrap byte array instead of copy to make a ByteString. 4. Moved all reflection instantiation to static class loading time. * Use LiteralByteString to wrap byte array instead of copying it. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]> (cherry picked from commit 72727ff) (cherry picked from commit ae3de38) (cherry picked from commit b8b8e0a)

…yncwal (apache#1301) (apache#1535) (apache#1567) * Use Reflection to access shaded Hadoop protobuf classes. (cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0) * Update to improve the code: 1. Added license. 2. Added more comments. 3. Wrap byte array instead of copy to make a ByteString. 4. Moved all reflection instantiation to static class loading time. * Use LiteralByteString to wrap byte array instead of copying it. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]> (cherry picked from commit 72727ff) (cherry picked from commit ae3de38) (cherry picked from commit b8b8e0a) (cherry picked from commit 6a2314d) Change-Id: Id87f30e022d36acbd629364e01e952954cce4460

saintstack merged commit b8b8e0a into apache:branch-2.3 Apr 17, 2020

jojochuang mentioned this pull request Apr 23, 2020

HBASE-24225 Backport HBASE-23833 to branch-2.2 #1567

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal #1535

HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal #1535

Uh oh!

jojochuang commented Apr 16, 2020 •

edited

Loading

Uh oh!

Apache-HBase commented Apr 16, 2020

Uh oh!

Apache-HBase commented Apr 16, 2020

Uh oh!

Apache-HBase commented Apr 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal #1535

HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal #1535

Uh oh!

Conversation

jojochuang commented Apr 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Apr 16, 2020

Uh oh!

Apache-HBase commented Apr 16, 2020

Uh oh!

Apache-HBase commented Apr 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jojochuang commented Apr 16, 2020 •

edited

Loading