Skip to content

Conversation

@binlijin
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 31s master passed
+1 💚 checkstyle 1m 11s master passed
+1 💚 spotbugs 2m 0s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 checkstyle 1m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 10m 44s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 2m 6s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
31m 30s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1506
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 625ca736285c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5f08311
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed, LGTM, +1

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 41s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 18s master passed
+1 💚 compile 1m 6s master passed
+1 💚 shadedjars 5m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 39s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 48s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 shadedjars 5m 20s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s the patch passed
_ Other Tests _
+1 💚 unit 207m 20s hbase-server in the patch passed.
235m 6s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1506
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7a5dca17b5b4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5f08311
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/testReport/
Max. process+thread count 3105 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 46s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 2s master passed
+1 💚 compile 1m 15s master passed
+1 💚 shadedjars 6m 14s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 47s hbase-server in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 33s the patch passed
+1 💚 compile 1m 15s the patch passed
+1 💚 javac 1m 15s the patch passed
+1 💚 shadedjars 6m 35s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 54s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 209m 18s hbase-server in the patch passed.
241m 32s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1506
Optional Tests javac javadoc unit shadedjars compile
uname Linux b1d387f00c23 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5f08311
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/testReport/
Max. process+thread count 2922 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1506/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@binlijin binlijin merged commit 92b30f2 into apache:master Apr 14, 2020
@binlijin
Copy link
Contributor Author

@HorizonNet @Reidddddd Thanks for the review.

asfgit pushed a commit that referenced this pull request Apr 14, 2020
asfgit pushed a commit that referenced this pull request Apr 14, 2020
asfgit pushed a commit that referenced this pull request Apr 14, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
Signed-off-by: Reid Chan <[email protected]>
Signed-off-by: Jan Hentschel <[email protected]>
(cherry picked from commit de7e6a3)

Change-Id: I0eac88aaa0a92c98481077e999facc55279ebc90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants