Skip to content

HBASE-24140 : Move CandidateGenerator and their implementors out of StochasticLoadBalancer #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
virajjasani merged 5 commits into from
Apr 12, 2020
Merged

HBASE-24140 : Move CandidateGenerator and their implementors out of StochasticLoadBalancer #1458

virajjasani merged 5 commits into from
Apr 12, 2020

Conversation

@virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Apr 8, 2020

…tochasticLoadBalancer

busbey
busbey requested changes Apr 8, 2020
View reviewed changes
@Apache-HBase
Copy link

Apache-HBase commented Apr 8, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 5m 26s master passed
+1 💚 checkstyle 1m 7s master passed
+1 💚 spotbugs 2m 1s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 54s the patch passed
+1 💚 checkstyle 1m 6s hbase-server: The patch generated 0 new + 28 unchanged - 5 fixed = 28 total (was 33)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 10m 13s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 2m 7s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
34m 21s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1458
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 9e3283e6faf7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ed83022
Max. process+thread count 93 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani requested a review from busbey April 8, 2020 18:09
@Apache-HBase
Copy link

Apache-HBase commented Apr 8, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
-1 ❌ mvninstall 5m 58s root in master failed.
+1 💚 checkstyle 1m 26s master passed
+1 💚 spotbugs 2m 55s master passed
_ Patch Compile Tests _
-1 ❌ mvninstall 5m 40s root in the patch failed.
-0 ⚠️ checkstyle 1m 25s hbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hadoopcheck 2m 56s The patch causes 16 errors with Hadoop v2.10.0.
-1 ❌ hadoopcheck 5m 41s The patch causes 16 errors with Hadoop v3.1.2.
+1 💚 spotbugs 2m 39s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
29m 6s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1458
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux b4db15cbd02a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ac6060c
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/patch-javac-2.10.0.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
Max. process+thread count 83 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 8, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 18s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
-1 ❌ mvninstall 7m 21s root in master failed.
+1 💚 compile 1m 22s master passed
-1 ❌ shadedjars 6m 17s branch has 16 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 1m 1s hbase-server in master failed.
_ Patch Compile Tests _
-1 ❌ mvninstall 6m 40s root in the patch failed.
+1 💚 compile 1m 19s the patch passed
+1 💚 javac 1m 19s the patch passed
-1 ❌ shadedjars 5m 18s patch has 16 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 40s hbase-server in the patch failed.
_ Other Tests _
-1 ❌ unit 184m 55s hbase-server in the patch failed.
219m 13s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1458
Optional Tests javac javadoc unit shadedjars compile
uname Linux ca6a423fe521 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2d78a28
Default Java 2020-01-14
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/testReport/
Max. process+thread count 3244 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 8, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
-1 ❌ mvninstall 5m 37s root in master failed.
+1 💚 compile 1m 2s master passed
-1 ❌ shadedjars 4m 52s branch has 16 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s master passed
_ Patch Compile Tests _
-1 ❌ mvninstall 4m 49s root in the patch failed.
+1 💚 compile 1m 19s the patch passed
+1 💚 javac 1m 19s the patch passed
-1 ❌ shadedjars 4m 41s patch has 16 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s the patch passed
_ Other Tests _
+1 💚 unit 212m 35s hbase-server in the patch passed.
239m 36s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1458
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9def92518ad1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ac6060c
Default Java 1.8.0_232
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/testReport/
Max. process+thread count 2541 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 9, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
-1 ❌ mvninstall 6m 1s root in master failed.
+1 💚 checkstyle 1m 18s master passed
+1 💚 spotbugs 2m 12s master passed
_ Patch Compile Tests _
-1 ❌ mvninstall 4m 51s root in the patch failed.
-0 ⚠️ checkstyle 1m 15s hbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hadoopcheck 2m 44s The patch causes 16 errors with Hadoop v2.10.0.
-1 ❌ hadoopcheck 5m 30s The patch causes 16 errors with Hadoop v3.1.2.
+1 💚 spotbugs 2m 21s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
26m 47s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1458
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 10f3456f981e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/patch-javac-2.10.0.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
Max. process+thread count 83 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 9, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
-1 ❌ mvninstall 4m 35s root in master failed.
+1 💚 compile 0m 52s master passed
-1 ❌ shadedjars 3m 56s branch has 16 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s master passed
_ Patch Compile Tests _
-1 ❌ mvninstall 4m 6s root in the patch failed.
+1 💚 compile 0m 54s the patch passed
+1 💚 javac 0m 54s the patch passed
-1 ❌ shadedjars 3m 57s patch has 16 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 32s the patch passed
_ Other Tests _
-1 ❌ unit 6m 0s hbase-server in the patch failed.
27m 23s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1458
Optional Tests javac javadoc unit shadedjars compile
uname Linux f4411935d85d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
Default Java 1.8.0_232
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/testReport/
Max. process+thread count 649 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 9, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 6m 54s master passed
+1 💚 checkstyle 1m 19s master passed
+1 💚 spotbugs 2m 29s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 6m 49s the patch passed
-0 ⚠️ checkstyle 1m 27s hbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 42s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 2m 23s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
44m 58s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1458
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux d56bef5f3ec0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2907260
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 83 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor Author

virajjasani commented Apr 9, 2020

@busbey Please review when you get time.
Thanks

@Apache-HBase
Copy link

Apache-HBase commented Apr 9, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 58s master passed
+1 💚 compile 1m 3s master passed
+1 💚 shadedjars 5m 15s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 39s hbase-server in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 58s the patch passed
+1 💚 compile 1m 4s the patch passed
+1 💚 javac 1m 4s the patch passed
+1 💚 shadedjars 5m 11s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 39s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 116m 56s hbase-server in the patch passed.
144m 41s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1458
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6daa31646183 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2907260
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/testReport/
Max. process+thread count 3762 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 9, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 55s master passed
+1 💚 compile 0m 56s master passed
+1 💚 shadedjars 4m 54s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 29s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 shadedjars 4m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 34s the patch passed
_ Other Tests _
+1 💚 unit 170m 45s hbase-server in the patch passed.
197m 8s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1458
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8c9bacb14abf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2907260
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/testReport/
Max. process+thread count 3127 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani requested a review from ramkrish86 April 11, 2020 09:45
@Apache-HBase
Copy link

Apache-HBase commented Apr 11, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 7m 21s master passed
+1 💚 checkstyle 1m 36s master passed
+1 💚 spotbugs 2m 47s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 6m 36s the patch passed
-0 ⚠️ checkstyle 1m 30s hbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 14m 49s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 2m 51s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
47m 10s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1458
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux c366631e9eac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 14342b6
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 93 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 11, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 21s master passed
+1 💚 compile 0m 55s master passed
+1 💚 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 0s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 shadedjars 4m 34s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s the patch passed
_ Other Tests _
+1 💚 unit 117m 14s hbase-server in the patch passed.
142m 26s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1458
Optional Tests javac javadoc unit shadedjars compile
uname Linux bc4dff52cfb8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 14342b6
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/testReport/
Max. process+thread count 3917 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 11, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 6m 6s master passed
+1 💚 compile 1m 3s master passed
+1 💚 shadedjars 5m 17s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 41s hbase-server in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 56s the patch passed
+1 💚 compile 1m 2s the patch passed
+1 💚 javac 1m 2s the patch passed
+1 💚 shadedjars 5m 12s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 38s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 121m 35s hbase-server in the patch passed.
150m 2s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1458
Optional Tests javac javadoc unit shadedjars compile
uname Linux 15544b4cca47 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 14342b6
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/testReport/
Max. process+thread count 4210 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani requested a review from HorizonNet April 12, 2020 08:54
@virajjasani virajjasani changed the title HBASE-24140 : Move CandidateGenerator and their implementors out of S… HBASE-24140 : Move CandidateGenerator and their implementors out of StochasticLoadBalancer Apr 12, 2020
@virajjasani virajjasani merged commit b6b8c69 into apache:master Apr 12, 2020
virajjasani added a commit that referenced this pull request Apr 12, 2020
@virajjasani
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
45622ab 
…tochasticLoadBalancer (#1458)

Signed-off-by: Jan Hentschel <[email protected]>
virajjasani added a commit that referenced this pull request Apr 12, 2020
@virajjasani
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
cd259d7 
…tochasticLoadBalancer (#1458)

Signed-off-by: Jan Hentschel <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
ccd1029 
…tochasticLoadBalancer (apache#1458)

Signed-off-by: Jan Hentschel <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
7b1f591 
…tochasticLoadBalancer (apache#1458)

Signed-off-by: Jan Hentschel <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani @thangTang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
9be00ec 
…tochasticLoadBalancer (apache#1458)

Signed-off-by: Jan Hentschel <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani @thangTang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
bc9c3a1 
…tochasticLoadBalancer (apache#1458)

Signed-off-by: Jan Hentschel <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani @thangTang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
24f3cd5 
…tochasticLoadBalancer (apache#1458)

Signed-off-by: Jan Hentschel <[email protected]>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
@virajjasani @ddupg
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
5179717 
…tochasticLoadBalancer (apache#1458)

Signed-off-by: Jan Hentschel <[email protected]>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@virajjasani
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
ac4b84c 
…tochasticLoadBalancer (apache#1458)

Signed-off-by: Jan Hentschel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

@busbey busbey Awaiting requested review from busbey

@saintstack saintstack Awaiting requested review from saintstack

@petersomogyi petersomogyi Awaiting requested review from petersomogyi

@anoopsjohn anoopsjohn Awaiting requested review from anoopsjohn

@Apache9 Apache9 Awaiting requested review from Apache9

@ramkrish86 ramkrish86 Awaiting requested review from ramkrish86

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@virajjasani @Apache-HBase @busbey @HorizonNet