Skip to content

HBASE-23971 protoc warns: "no protobuf syntax specified" #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saintstack merged 5 commits into from
Mar 12, 2020
Merged

HBASE-23971 protoc warns: "no protobuf syntax specified" #1278

saintstack merged 5 commits into from
Mar 12, 2020

Conversation

@WenFeiYi
Copy link
Contributor

@WenFeiYi WenFeiYi commented Mar 12, 2020

No description provided.

@Apache-HBase
Copy link

Apache-HBase commented Mar 12, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
-0 ⚠️ patch 1m 11s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hbaseprotoc 0m 12s hbase-endpoint in the patch failed.
-1 ❌ hbaseprotoc 0m 12s hbase-examples in the patch failed.
-1 ❌ hbaseprotoc 0m 9s hbase-rest in the patch failed.
_ Other Tests _
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
6m 25s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1278
Optional Tests dupname asflicense cc hbaseprotoc prototool
uname Linux 5b3d356e1b14 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 20658c5
hbaseprotoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-endpoint.txt
hbaseprotoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-examples.txt
hbaseprotoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-rest.txt
Max. process+thread count 62 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-endpoint hbase-examples hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Mar 12, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 14s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for branch
+1 💚 mvninstall 7m 11s master passed
-0 ⚠️ patch 8m 30s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 6m 57s the patch passed
_ Other Tests _
+1 💚 unit 0m 55s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 33s hbase-protocol in the patch passed.
+1 💚 unit 3m 20s hbase-endpoint in the patch passed.
+1 💚 unit 2m 46s hbase-rest in the patch passed.
+1 💚 unit 1m 33s hbase-examples in the patch passed.
27m 0s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1278
Optional Tests unit
uname Linux 0de3319aefb0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 20658c5
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/testReport/
Max. process+thread count 3065 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-endpoint hbase-rest hbase-examples U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Mar 12, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 58s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for branch
+1 💚 mvninstall 5m 53s master passed
-0 ⚠️ patch 7m 11s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 5m 58s the patch passed
_ Other Tests _
+1 💚 unit 0m 54s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 33s hbase-protocol in the patch passed.
+1 💚 unit 3m 26s hbase-endpoint in the patch passed.
+1 💚 unit 3m 55s hbase-rest in the patch passed.
+1 💚 unit 1m 37s hbase-examples in the patch passed.
27m 48s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1278
Optional Tests unit
uname Linux ee6bf5aeb88d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 20658c5
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/testReport/
Max. process+thread count 2682 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-endpoint hbase-rest hbase-examples U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some proto files have the proto2 syntax qualifier already?

Otherwise this patch LGTM.

@WenFeiYi
Copy link
Contributor Author

WenFeiYi commented Mar 12, 2020

Some proto files have the proto2 syntax qualifier already?

Otherwise this patch LGTM.

yes, I browsed all, other proto files hava the 'proto2 syntax'.

@Apache-HBase
Copy link

Apache-HBase commented Mar 12, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 5m 20s master passed
+1 💚 checkstyle 2m 13s master passed
-1 ❌ spotbugs 1m 58s hbase-server in master has 1 extant spotbugs warnings.
-0 ⚠️ patch 2m 44s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 5m 4s the patch passed
+1 💚 checkstyle 2m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 16m 9s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 hbaseprotoc 3m 27s the patch passed
+1 💚 spotbugs 9m 16s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 14s The patch does not generate ASF License warnings.
62m 35s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1278
Optional Tests dupname asflicense cc hbaseprotoc prototool spotbugs hadoopcheck hbaseanti checkstyle
uname Linux e3d6cc965be1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 26f3702
spotbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
Max. process+thread count 93 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-server hbase-endpoint hbase-rest hbase-examples U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Mar 12, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 5m 50s master passed
+1 💚 compile 3m 44s master passed
+1 💚 shadedjars 5m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 53s master passed
-0 ⚠️ patch 8m 6s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 5m 49s the patch passed
+1 💚 compile 3m 33s the patch passed
+1 💚 javac 3m 33s the patch passed
+1 💚 shadedjars 5m 22s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 57s the patch passed
_ Other Tests _
+1 💚 unit 0m 43s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 27s hbase-protocol in the patch passed.
-1 ❌ unit 148m 12s hbase-server in the patch failed.
+1 💚 unit 4m 21s hbase-endpoint in the patch passed.
+1 💚 unit 5m 0s hbase-rest in the patch passed.
+1 💚 unit 2m 26s hbase-examples in the patch passed.
198m 41s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1278
Optional Tests unit javac javadoc shadedjars compile
uname Linux 51c2ffcd989c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 26f3702
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/testReport/
Max. process+thread count 3648 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-server hbase-endpoint hbase-rest hbase-examples U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Mar 12, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 7m 30s master passed
+1 💚 compile 4m 39s master passed
+1 💚 shadedjars 5m 46s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 21s hbase-examples in master failed.
-0 ⚠️ javadoc 0m 25s hbase-rest in master failed.
-0 ⚠️ javadoc 0m 43s hbase-server in master failed.
-0 ⚠️ patch 8m 50s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 7m 4s the patch passed
+1 💚 compile 4m 27s the patch passed
+1 💚 javac 4m 27s the patch passed
+1 💚 shadedjars 6m 22s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 1m 2s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 37s hbase-rest in the patch failed.
-0 ⚠️ javadoc 0m 32s hbase-examples in the patch failed.
_ Other Tests _
+1 💚 unit 1m 18s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 53s hbase-protocol in the patch passed.
-0 ⚠️ unit 153m 33s hbase-server in the patch failed.
+1 💚 unit 3m 2s hbase-endpoint in the patch passed.
+1 💚 unit 3m 13s hbase-rest in the patch passed.
+1 💚 unit 1m 41s hbase-examples in the patch passed.
208m 33s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1278
Optional Tests unit javac javadoc shadedjars compile
uname Linux d669637760f8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 26f3702
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/testReport/
Max. process+thread count 3892 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-protocol hbase-server hbase-endpoint hbase-rest hbase-examples U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack saintstack merged commit abf0a22 into apache:master Mar 12, 2020
asfgit pushed a commit that referenced this pull request Mar 17, 2020
@saintstack
HBASE-23971 protoc warns: "no protobuf syntax specified" (#1278)
9804f73 
Remove overcommit in TestUsersOperationsWithSecureHadoop
(Noticed by ndimiduk)
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@WenFeiYi @thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
9077bcc 
Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack @thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
e98f9b9 
Remove overcommit in TestUsersOperationsWithSecureHadoop
(Noticed by ndimiduk)
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@WenFeiYi @thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
aecb6f4 
Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack @thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
0de55e4 
Remove overcommit in TestUsersOperationsWithSecureHadoop
(Noticed by ndimiduk)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstack saintstack saintstack left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WenFeiYi @Apache-HBase @saintstack