-
Notifications
You must be signed in to change notification settings - Fork 52
HBASE-29225 [hbase-thirdparty] Add module for Jetty 12 with EE8 and add support for toolchain based JDK selection #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
b89aaa8
cbcf523
f1b5d2f
7d7b2ef
86ed68c
f729cc4
53eb62d
f566a92
a684c37
681e54d
39fac5c
1500c1d
0eb4072
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,4 @@ hbase-shaded-protobuf/src/main/resources | |
| .idea | ||
| *.iml | ||
| .flattened-pom.xml | ||
| toolchains.xml | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| #!/usr/bin/env bash | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # Script to generate toolchains.xml with configurable Java paths | ||
|
|
||
| # Set default paths if environment variables are not set | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is great.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @stoty yes you are absolutely right, release script would need some patching to understanding toolchains. Will take this up as part of release process. Thanks for highlighting.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created HBASE-29490 |
||
| if [ -z "$JAVA8_HOME" ]; then | ||
| echo "Trying to detect Java 8 installation (Jenkins/CI standard path)" | ||
| if [ -d "/usr/lib/jvm/java-8" ]; then | ||
| JAVA8_HOME="/usr/lib/jvm/java-8" | ||
| else | ||
| echo "Warning: JAVA8_HOME not set and Java 8 not found at /usr/lib/jvm/java-8" | ||
| echo "For local development, please set JAVA8_HOME environment variable" | ||
| JAVA8_HOME="/usr/lib/jvm/java-8" | ||
| fi | ||
| fi | ||
|
|
||
| if [ -z "$JAVA17_HOME" ]; then | ||
| echo "Trying to detect Java 17 installation (Jenkins/CI standard path)" | ||
| if [ -d "/usr/lib/jvm/java-17" ]; then | ||
| JAVA17_HOME="/usr/lib/jvm/java-17" | ||
| else | ||
| echo "Warning: JAVA17_HOME not set and Java 17 not found at /usr/lib/jvm/java-17" | ||
| echo "For local development, please set JAVA17_HOME environment variable" | ||
| JAVA17_HOME="/usr/lib/jvm/java-17" | ||
| fi | ||
| fi | ||
|
|
||
| echo "Generating toolchains.xml with:" | ||
| echo " JAVA8_HOME: $JAVA8_HOME" | ||
| echo " JAVA17_HOME: $JAVA17_HOME" | ||
|
|
||
| # Generate toolchains.xml | ||
| cat > toolchains.xml << EOF | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <toolchains xmlns="http://maven.apache.org/TOOLCHAINS/1.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/TOOLCHAINS/1.1.0 http://maven.apache.org/xsd/toolchains-1.1.0.xsd"> | ||
| <!-- | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| --> | ||
| <toolchain> | ||
| <type>jdk</type> | ||
| <provides> | ||
| <version>1.8</version> | ||
| </provides> | ||
| <configuration> | ||
| <jdkHome>$JAVA8_HOME</jdkHome> | ||
| </configuration> | ||
| </toolchain> | ||
| <toolchain> | ||
| <type>jdk</type> | ||
| <provides> | ||
| <version>17</version> | ||
| </provides> | ||
| <configuration> | ||
| <jdkHome>$JAVA17_HOME</jdkHome> | ||
| </configuration> | ||
| </toolchain> | ||
| </toolchains> | ||
| EOF | ||
|
|
||
| echo "toolchains.xml generated successfully!" | ||
Uh oh!
There was an error while loading. Please reload this page.