Skip to content

Conversation

@NihalJain
Copy link
Contributor

  • It is not very useful to version the patch files as we already are under version control via git.

@NihalJain NihalJain requested review from ndimiduk and stoty May 20, 2025 17:49
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 0m 48s master passed
+1 💚 javadoc 0m 15s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
+1 💚 unit 0m 12s hbase-shaded-protobuf in the patch passed.
+1 💚 unit 0m 48s root in the patch passed.
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
4m 48s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-138/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #138
Optional Tests dupname asflicense javac javadoc unit markdownlint
uname Linux ac731265e6ef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / ad09819
Default Java Temurin-1.8.0_452-b09
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-138/1/testReport/
Max. process+thread count 386 (vs. ulimit of 1000)
modules C: hbase-shaded-protobuf . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-138/1/console
versions git=2.43.0 maven=3.9.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@NihalJain NihalJain merged commit 223f4c6 into apache:master May 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants