Skip to content

Conversation

@richardantal
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 40s master passed
+1 💚 compile 0m 55s master passed
+1 💚 spotless 0m 14s branch has no errors when running spotless:check.
+1 💚 javadoc 0m 55s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 52s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 spotless 0m 11s patch has no errors when running spotless:check.
+1 💚 javadoc 0m 53s the patch passed
_ Other Tests _
+1 💚 unit 9m 17s root in the patch passed.
17m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-148/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #148
Optional Tests dupname javac javadoc unit spotless xml compile
uname Linux 48c09729b5d8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / f5d80c2
Default Java Oracle Corporation-1.8.0_342-b07
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-148/1/testReport/
Max. process+thread count 967 (vs. ulimit of 12500)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-148/1/console
versions git=2.30.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Copy link

@PDavid PDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good, thanks.

Copy link

@aminadinari19 aminadinari19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@NihalJain
Copy link
Contributor

just curious. i thought we can build hbase connectors with jdk 17 after ac5d120

@richardantal
Copy link
Contributor Author

We only have issues with extra maven parameters to force java17 class files generated.

-Dmaven.compiler.source=17 -Dmaven.compiler.target=17 -Dmaven.compiler.release=17

@NihalJain
Copy link
Contributor

We only have issues with extra maven parameters to force java17 class files generated.

-Dmaven.compiler.source=17 -Dmaven.compiler.target=17 -Dmaven.compiler.release=17

Gotcha thanks for the clarification.

@taklwu taklwu merged commit cd37144 into apache:master Sep 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants