HBASE-29287 Update HBase version used in connectors to 2.6.2 #144

stoty · 2025-05-07T08:33:17Z

also update

hadoop to 3.4.1
hbase-thirdparty to 4.11.0
mockito to 4.11.0
surefire to 3.5.2
commons-lang to 3.17.0

stoty · 2025-05-07T08:35:42Z

The test will fail here because this needs #143 (with the correctly upated protobuf 4.x version from hbase-thirdparty 4.10.0)

stoty · 2025-05-07T08:36:01Z

spark-it is also likely to fail even with #143 because of shading and version conflicts in the minicluster

Apache-HBase · 2025-05-07T09:03:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 23s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 30s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	spotless	0m 15s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 50s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 50s	root in the patch failed.
-1 ❌	compile	0m 51s	root in the patch failed.
-1 ❌	javac	0m 51s	root in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	spotless	0m 11s	patch has no errors when running spotless:check.
-1 ❌	javadoc	0m 51s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	5m 28s	root in the patch failed.
		14m 48s

Reason	Tests
Failed junit tests	hadoop.hbase.spark.DefaultSourceSuite
	hadoop.hbase.spark.PartitionFilterSuite

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#144
Optional Tests	dupname javac javadoc unit spotless xml compile
uname	Linux 881fe2cf8a1e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `af4230c`
Default Java	Oracle Corporation-1.8.0_282-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/artifact/yetus-precommit-check/output/patch-javadoc-root.txt
unit	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/testReport/
Max. process+thread count	893 (vs. ulimit of 12500)
modules	C: spark/hbase-spark spark/hbase-spark-it . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/1/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2025-05-07T10:39:46Z

The rebase fixes the protobuf issue, but not the spark-it shading conflicts.

That requires more work.

Apache-HBase · 2025-05-07T11:06:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 37s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	spotless	0m 14s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 53s	root in the patch failed.
-1 ❌	compile	0m 52s	root in the patch failed.
-1 ❌	javac	0m 52s	root in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	spotless	0m 11s	patch has no errors when running spotless:check.
-1 ❌	javadoc	0m 51s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	9m 6s	root in the patch failed.
		17m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#144
Optional Tests	dupname javac javadoc unit spotless xml compile
uname	Linux 576ae210b957 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `b850f82`
Default Java	Oracle Corporation-1.8.0_282-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/artifact/yetus-precommit-check/output/patch-compile-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/artifact/yetus-precommit-check/output/patch-javadoc-root.txt
unit	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/testReport/
Max. process+thread count	964 (vs. ulimit of 12500)
modules	C: spark/hbase-spark spark/hbase-spark-it . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/2/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-07T12:36:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 30s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	spotless	0m 15s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 53s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	spotless	0m 11s	patch has no errors when running spotless:check.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 22s	root in the patch passed.
		17m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#144
Optional Tests	dupname javac javadoc unit spotless xml compile
uname	Linux 794959581b18 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `b850f82`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/3/testReport/
Max. process+thread count	968 (vs. ulimit of 12500)
modules	C: spark/hbase-spark spark/hbase-spark-it hbase-connectors-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/3/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-09T06:08:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 26s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	spotless	0m 14s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 54s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
-1 ❌	spotless	0m 12s	patch has 59 errors when running spotless:check, run spotless:apply to fix.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 15s	root in the patch passed.
		18m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/4/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#144
Optional Tests	dupname javac javadoc unit spotless xml compile
uname	Linux f93a9b3f7458 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `b850f82`
Default Java	Oracle Corporation-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/4/artifact/yetus-precommit-check/output/patch-spotless.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/4/testReport/
Max. process+thread count	966 (vs. ulimit of 12500)
modules	C: spark/hbase-spark spark/hbase-spark-it hbase-connectors-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/4/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

also update * hadoop to 3.4.1 * hbase-thirdparty to 4.11.0 * mockito to 4.11.0 * surefire to 3.5.2 * commons-lang to 3.17.0 Co-authored-by: Villő Szűcs <[email protected]>

Apache-HBase · 2025-05-09T06:52:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 20s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	spotless	0m 13s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 48s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 54s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	spotless	0m 11s	patch has no errors when running spotless:check.
+1 💚	javadoc	0m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 6s	root in the patch passed.
		17m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/5/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#144
Optional Tests	dupname javac javadoc unit spotless xml compile
uname	Linux 16ebd98803a2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `b850f82`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/5/testReport/
Max. process+thread count	966 (vs. ulimit of 12500)
modules	C: spark/hbase-spark spark/hbase-spark-it hbase-connectors-assembly . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-144/5/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain

+1, LGTM

also having hadoop two was quite troublesome for IT. we used to build internally by setting hadoop two = hadoop three as a hack 🤦‍♂️

stoty · 2025-05-09T08:01:17Z

Thank you.

I've started a DISCUSS thread to remove Hadoop 2 support from connectors, please comment on that .

stoty marked this pull request as draft May 7, 2025 08:33

stoty mentioned this pull request May 7, 2025

HBASE-29286 Use thirdparty protoc version when generating spark connector protobuf classes #143

Merged

NihalJain mentioned this pull request May 7, 2025

HBASE-29165 Bump hbase-connectors hbase version to 2.6.2 #142

Closed

stoty force-pushed the HBASE-29287 branch from db73378 to 631079c Compare May 7, 2025 10:38

stoty force-pushed the HBASE-29287 branch from 631079c to 7fa3449 Compare May 7, 2025 12:04

stoty force-pushed the HBASE-29287 branch from 7fa3449 to bb7d495 Compare May 9, 2025 05:41

HBASE-29287 Update HBase version used in connectors to 2.6.2

c79949f

also update * hadoop to 3.4.1 * hbase-thirdparty to 4.11.0 * mockito to 4.11.0 * surefire to 3.5.2 * commons-lang to 3.17.0 Co-authored-by: Villő Szűcs <[email protected]>

stoty force-pushed the HBASE-29287 branch from bb7d495 to c79949f Compare May 9, 2025 06:27

stoty marked this pull request as ready for review May 9, 2025 07:21

stoty requested review from NihalJain, meszibalu and ndimiduk May 9, 2025 07:21

NihalJain approved these changes May 9, 2025

View reviewed changes

stoty merged commit 800161e into apache:master May 12, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-29287 Update HBase version used in connectors to 2.6.2 #144

HBASE-29287 Update HBase version used in connectors to 2.6.2 #144

Uh oh!

stoty commented May 7, 2025

Uh oh!

stoty commented May 7, 2025 •

edited

Loading

Uh oh!

stoty commented May 7, 2025 •

edited

Loading

Uh oh!

Apache-HBase commented May 7, 2025

Uh oh!

stoty commented May 7, 2025 •

edited

Loading

Uh oh!

Apache-HBase commented May 7, 2025

Uh oh!

Apache-HBase commented May 7, 2025

Uh oh!

Apache-HBase commented May 9, 2025

Uh oh!

Apache-HBase commented May 9, 2025

Uh oh!

NihalJain left a comment

Uh oh!

stoty commented May 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-29287 Update HBase version used in connectors to 2.6.2 #144

HBASE-29287 Update HBase version used in connectors to 2.6.2 #144

Uh oh!

Conversation

stoty commented May 7, 2025

Uh oh!

stoty commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stoty commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented May 7, 2025

Uh oh!

stoty commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented May 7, 2025

Uh oh!

Apache-HBase commented May 7, 2025

Uh oh!

Apache-HBase commented May 9, 2025

Uh oh!

Apache-HBase commented May 9, 2025

Uh oh!

NihalJain left a comment

Choose a reason for hiding this comment

Uh oh!

stoty commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stoty commented May 7, 2025 •

edited

Loading

stoty commented May 7, 2025 •

edited

Loading

stoty commented May 7, 2025 •

edited

Loading

stoty commented May 9, 2025 •

edited

Loading