Skip to content

HBASE-28790 hbase-connectors fails to build with hbase 2.6.0 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NihalJain merged 1 commit into from
Oct 3, 2024
Merged

HBASE-28790 hbase-connectors fails to build with hbase 2.6.0 #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/KafkaBridgeConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,14 @@ public TableBuilder setWriteRpcTimeout(int timeout) {
return null;
}

/**
* This method was added in HBASE-27657. We donot add @Override to allow code to compile with
* versions of hbase both having and not having HBASE-27657
**/
public TableBuilder setRequestAttribute(String key, byte[] value) {
Copy link
Member

@ndimiduk ndimiduk Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fragile approach. This repository needs sureing up if it is going to intentionally support multiple minor versions of HBase. At the minimum, we need an HBase versions check in our pre-commit and nightlies, similar to what HBase has for Hadoop.

return null;
}

@Override
public Table build() {
return new KafkaTableForBridge(tn, passedInConfiguration, routingRules, producer,
Expand Down