HBASE-28382 Support building hbase-connectors with JDK17 #132

NihalJain · 2024-08-17T09:43:56Z

Remove EOL'ed gmaven-plugin which is unnecessarily too complex and does not work with JDK17
Refactor flags for UT and IT for ease of profile based run
Copy JDK17 flags from HBase and Spark
Add profile for JDK11 and JDK17 build

NihalJain · 2024-08-17T09:44:36Z

Marking as draft, will self review first and make it non-draft later!

Apache-HBase · 2024-08-17T11:50:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 30s	master passed
+1 💚	compile	0m 52s	master passed
+1 💚	spotless	0m 15s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 49s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	spotless	0m 12s	patch has no errors when running spotless:check.
+1 💚	javadoc	0m 49s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 20s	root in the patch passed.
		17m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-132/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#132
Optional Tests	dupname javac javadoc unit spotless xml compile
uname	Linux 7c93e945b9cd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `1498a91`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-132/1/testReport/
Max. process+thread count	942 (vs. ulimit of 12500)
modules	C: spark spark/hbase-spark spark/hbase-spark-it . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-132/1/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-09-23T06:53:27Z

Hi @Reidddddd would you be able to review this one?

ndimiduk · 2024-09-23T16:00:20Z

Can you also update the Jenkinsfile with additional stages so that we test builds on all the supported JVM major versions?

ndimiduk · 2024-09-23T16:00:49Z

That is, I assume that this commit does not also deprecate the JDK11 (and JDK8?) support.

NihalJain · 2024-09-23T16:27:12Z

Hi @ndimiduk thank you for having a look at this one.

Can you also update the Jenkinsfile with additional stages so that we test builds on all the supported JVM major versions?

Sure I had created a sub task to handle the build part: HBASE-28789. But I could update the current PR as well to take care of same. Let me know how I should proceed.

That is, I assume that this commit does not also deprecate the JDK11 (and JDK8?) support.

Yes it does not deprecate JDK8 support.

ndimiduk · 2024-09-23T17:11:11Z

Ah okay. Sorry, I only looked at the PR, not Jira.

Yes, I think it would be nice if it all happened together because then the new pre-commit checker will verify the code before it lands in the repo. Only if one or the other change ends up being too big for reviews to be practical would I separate them.

NihalJain · 2024-09-24T08:56:41Z

Yes, I think it would be nice if it all happened together because then the new pre-commit checker will verify the code before it lands in the repo.

Sure let me work and update this PR with Jenkins related changes as well.

pom.xml

stoty · 2025-05-15T08:31:52Z

Care to rebase this @NihalJain ?

NihalJain · 2025-05-15T13:27:09Z

Care to rebase this @NihalJain ?

Sure @stoty

pom.xml

NihalJain · 2025-05-15T16:31:30Z

pom.xml

+      -verbose:gc -XX:+PrintCommandLineFlags  -XX:+PrintFlagsFinal -XX:+IgnoreUnrecognizedVMOptions</spark-it.args>
+    <spark-it.argLine>${argLine} ${spark-it.args}</spark-it.argLine>
+    <hbase-surefire.argLine>-Djava.security.manager=allow</hbase-surefire.argLine>
+    <hbase-surefire.jdk11.flags>-Dorg.apache.hbase.thirdparty.io.netty.tryReflectionSetAccessible=true


do we need jdk11 any more? i think should drop this altogether and be only on jdk17?

just double checked, branch-2.6 still has jdk11

pom.xml

…'ed gmaven-plugin which is unnecessarily too complex and does not work with JDK17 - Refactor flags for UT and IT for ease of profile based run - Bump and replace mockito-all with mockito-bom and update dependencies as needed - Copy JDK17 flags from HBase and Spark - Add profile for JDK11 and JDK17 build

Apache-HBase · 2025-05-15T17:36:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	1m 39s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	spotless	0m 16s	branch has no errors when running spotless:check.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for patch
+1 💚	mvninstall	0m 51s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	spotless	0m 11s	patch has no errors when running spotless:check.
+1 💚	javadoc	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 2s	root in the patch passed.
		17m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-132/4/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#132
Optional Tests	dupname javac javadoc unit spotless xml compile
uname	Linux aa03f8ba036e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool	hb_maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `800161e`
Default Java	Oracle Corporation-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-132/4/testReport/
Max. process+thread count	972 (vs. ulimit of 12500)
modules	C: spark spark/hbase-spark spark/hbase-spark-it . U: .
Console output	https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-132/4/console
versions	git=2.20.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-05-15T17:46:16Z

Sorry for the noise. I messed up by rebasing and pushing an older version of this PR in another local fork of mine.

I have run build with JDK 17 in local. Works fine.

For Nick's comment I would prefer to do this as another commit (of course if this is fine for everyone). Also maybe it's time we try to move to Github actions for build taking hbase-connectors project as PoC.

stoty

+1 LGTM

NihalJain marked this pull request as draft August 17, 2024 09:44

NihalJain force-pushed the HBASE-28382 branch 2 times, most recently from 657573e to 35f6a8b Compare August 17, 2024 11:18

NihalJain marked this pull request as ready for review August 17, 2024 11:21

NihalJain requested review from Apache9, Reidddddd, ndimiduk and petersomogyi August 17, 2024 11:22

stoty reviewed Oct 9, 2024

View reviewed changes

pom.xml Show resolved Hide resolved

NihalJain mentioned this pull request Dec 19, 2024

HBASE-28790 hbase-connectors fails to build with hbase 2.6.0 #133

Merged

NihalJain force-pushed the HBASE-28382 branch from 35f6a8b to 4712f1b Compare May 15, 2025 16:26

NihalJain commented May 15, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

NihalJain force-pushed the HBASE-28382 branch from 4712f1b to f2740d1 Compare May 15, 2025 16:30

NihalJain commented May 15, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

NihalJain force-pushed the HBASE-28382 branch from f2740d1 to 273c507 Compare May 15, 2025 16:44

This comment was marked as outdated.

Sign in to view

NihalJain force-pushed the HBASE-28382 branch from 273c507 to 69336c7 Compare May 15, 2025 17:04

NihalJain force-pushed the HBASE-28382 branch from 69336c7 to d46ce66 Compare May 15, 2025 17:14

NihalJain requested a review from stoty May 15, 2025 17:47

stoty approved these changes May 16, 2025

View reviewed changes

NihalJain merged commit ac5d120 into apache:master May 16, 2025
1 check passed

HBASE-28382 Support building hbase-connectors with JDK17 #132

HBASE-28382 Support building hbase-connectors with JDK17 #132

Uh oh!

Conversation

NihalJain commented Aug 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NihalJain commented Aug 17, 2024

Uh oh!

Apache-HBase commented Aug 17, 2024

Uh oh!

NihalJain commented Sep 23, 2024

Uh oh!

ndimiduk commented Sep 23, 2024

Uh oh!

ndimiduk commented Sep 23, 2024

Uh oh!

NihalJain commented Sep 23, 2024

Uh oh!

ndimiduk commented Sep 23, 2024

Uh oh!

NihalJain commented Sep 24, 2024

Uh oh!

Uh oh!

stoty commented May 15, 2025

Uh oh!

NihalJain commented May 15, 2025

Uh oh!

Uh oh!

NihalJain May 15, 2025

Choose a reason for hiding this comment

Uh oh!

NihalJain May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented May 15, 2025

Uh oh!

NihalJain commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NihalJain commented Aug 17, 2024 •

edited

Loading

NihalJain commented May 15, 2025 •

edited

Loading