Skip to content

HBASE-28137 Add scala-parser-combinators dependency to connectors for… #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
petersomogyi merged 2 commits into from
Oct 9, 2023
Merged

HBASE-28137 Add scala-parser-combinators dependency to connectors for… #125

petersomogyi merged 2 commits into from
Oct 9, 2023

Conversation

@stoty
Copy link
Contributor

@stoty stoty commented Oct 6, 2023 •
edited
Loading

… Spark 3.4.1

@stoty stoty marked this pull request as draft October 6, 2023 14:50
@stoty
Copy link
Contributor Author

stoty commented Oct 6, 2023 •
edited
Loading

Are you OK with this being commited with you as the author @attilapiros ?

@Apache-HBase
Copy link

Apache-HBase commented Oct 6, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 43s master passed
+1 💚 compile 0m 37s master passed
+1 💚 spotless 0m 14s branch has no errors when running spotless:check.
+1 💚 javadoc 0m 38s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 45s the patch passed
+1 💚 compile 0m 37s the patch passed
+1 💚 javac 0m 37s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 0s The patch has no ill-formed XML file.
+1 💚 spotless 0m 11s patch has no errors when running spotless:check.
+1 💚 javadoc 0m 37s the patch passed
_ Other Tests _
+1 💚 unit 8m 3s hbase-spark in the patch passed.
15m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #125
Optional Tests dupname javac javadoc unit spotless xml compile
uname Linux 9ea09918f396 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / f3cfa85
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/1/testReport/
Max. process+thread count 946 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/1/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@attilapiros @stoty
HBASE-28137 Add scala-parser-combinators dependency to connectors for…
f759a4e 
… Spark 3.4.1

Change-Id: Iafa91186866c45447e11534e401a2cdddd81b53d
@stoty stoty marked this pull request as ready for review October 7, 2023 05:58
@Apache-HBase
Copy link

Apache-HBase commented Oct 7, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 1m 34s master passed
+1 💚 compile 0m 41s master passed
+1 💚 spotless 0m 15s branch has no errors when running spotless:check.
+1 💚 javadoc 0m 42s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 0m 41s the patch passed
+1 💚 javac 0m 41s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 spotless 0m 12s patch has no errors when running spotless:check.
+1 💚 javadoc 0m 40s the patch passed
_ Other Tests _
+1 💚 unit 8m 36s hbase-spark in the patch passed.
16m 29s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #125
Optional Tests dupname javac javadoc unit spotless xml compile
uname Linux 788a031bba55 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / f3cfa85
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/2/testReport/
Max. process+thread count 941 (vs. ulimit of 12500)
modules C: spark/hbase-spark U: spark/hbase-spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/2/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi
petersomogyi reviewed Oct 9, 2023
View reviewed changes
spark/hbase-spark/pom.xml Outdated
<dependency>
<groupId>org.scala-lang.modules</groupId>
<artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
<version>1.1.2</version>
Copy link
Contributor

@petersomogyi petersomogyi Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract this version to a property?

Copy link
Contributor Author

@stoty stoty Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, @petersomogyi .

@stoty
extract version to property
1ea982c 
Change-Id: I1e56879839a6bf7d6da0993faaf28b452d649b6f
@stoty
Copy link
Contributor Author

stoty commented Oct 9, 2023

We should have 3.4 instead of 3.4.1 in the commit message.
Please update in commit, or I will update it tomorrow in the PR

@Apache-HBase
Copy link

Apache-HBase commented Oct 9, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 1m 29s master passed
+1 💚 compile 1m 29s master passed
+1 💚 spotless 0m 16s branch has no errors when running spotless:check.
+1 💚 javadoc 1m 26s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 1m 26s the patch passed
+1 💚 javac 1m 26s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 spotless 0m 12s patch has no errors when running spotless:check.
+1 💚 javadoc 1m 25s the patch passed
_ Other Tests _
+1 💚 unit 8m 52s spark in the patch passed.
+1 💚 unit 8m 43s hbase-spark in the patch passed.
28m 38s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #125
Optional Tests dupname javac javadoc unit spotless xml compile
uname Linux 889f958d2f2b 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 GNU/Linux
Build tool hb_maven
Personality dev-support/jenkins/hbase-personality.sh
git revision master / f3cfa85
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/3/testReport/
Max. process+thread count 945 (vs. ulimit of 12500)
modules C: spark spark/hbase-spark U: spark
Console output https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-125/3/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi
petersomogyi approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@petersomogyi petersomogyi merged commit 1fb67c9 into apache:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyi petersomogyi petersomogyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stoty @Apache-HBase @petersomogyi @attilapiros