-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Update RocksDB version to 6.0.1 #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bharatviswa504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM, pending CI.
|
💔 -1 overall
This message was automatically generated. |
|
Test failures look unrelated to this patch. |
|
I found the Jira for this. |
1. To disambiguate between YARN containers and Samza Processor. 2. Use consistent logging format. Now can search logs with strings "Container ID: <id>", "Processor ID: <id>", and "host: <hostname>" to find all relevant information for the container / processor / host. 3. Removed references to "preferred host" in logs when host affinity is disabled. Left StandbyContainerMangager as is for now. Will update it in a separate PR. Without Host Affinity Before: https://0bin.net/paste/VwqKIK2ADNCrycb-#UiOWKLYwnphA72uwXcj4wQzSX3MVqM8+qT+FY+3-tQJ After: https://0bin.net/paste/ts+fifnScrpKpIkU#nZ0RhSaqImzHNheYBbK4ROxICnehLPzPnwHFFY+Xj1Z With Host Affinity: Before: https://0bin.net/paste/6Z5914FWYWJuCGo3#76r4QO+K8SX9NBJyT7yfp9Mi25-N0pzmDmIxuknEipy After: https://0bin.net/paste/fBKJyYqHTtn41CMZ#35MEGwpsgQjeoNf0U1lnIQqywlW2vm+qim3dI3mRxfb Author: Prateek Maheshwari <[email protected]> Reviewers: Jagadish Venkatraman <[email protected]>, Ray Matharu <[email protected]> Closes apache#980 from prateekm/am-metrics
In RocksDb 6.0.1, some useful tuning features were brought into the JNI API. We need to upgrade the version in ozone to pick those up.
facebook/rocksdb#4833