Skip to content

HDDS-1587. Support dynamically adding delegated classes from to isolated class loader. #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoyuyao merged 5 commits into from
Jun 13, 2019
Merged

HDDS-1587. Support dynamically adding delegated classes from to isolated class loader. #942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c923db
HDDS-1587. Support dynamically adding delegated classes from to isola…
chenjunjiedada Jun 11, 2019
7f4c801
HDDS-1587: address comments
chenjunjiedada Jun 12, 2019
a4f425c
HDDS-1587: add unit test for FilteredClassLoader
chenjunjiedada Jun 12, 2019
8eb47c7
HDDS-1587: add license header
chenjunjiedada Jun 12, 2019
8f9824e
HDDS-1587: fix coding style
chenjunjiedada Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hadoop-ozone/common/src/main/bin/ozone-config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,8 @@ else
exit 1
fi

# HADOOP_OZONE_DELEGATED_CLASSES defines a list of classes which will be loaded by default
# class loader of application instead of isolated class loader. With this way we can solve
# incompatible problem when using hadoop3.x + ozone with older hadoop version.
#export HADOOP_OZONE_DELEGATED_CLASSES=
Copy link
Contributor

@xiaoyuyao xiaoyuyao Jun 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not work because we expect to expose an environment variable but the code in FilteredClassLoader only load a system property.

Copy link
Contributor Author

@chenjunjiedada chenjunjiedada Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.


6 changes: 6 additions & 0 deletions hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/FilteredClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ public FilteredClassLoader(URL[] urls, ClassLoader parent) {
delegatedClasses.add("org.apache.hadoop.fs.ozone.OzoneFSStorageStatistics");
delegatedClasses.add("org.apache.hadoop.fs.ozone.Statistic");
delegatedClasses.add("org.apache.hadoop.fs.Seekable");
String[] dynamicDelegatedClasses =
System.getProperty("HADOOP_OZONE_DELEGATED_CLASSES").split(";");
for (String delegatedClass : dynamicDelegatedClasses) {
delegatedClasses.add(delegatedClass);
}

this.delegate = parent;
systemClassLoader = getSystemClassLoader();

Expand Down