HDDS-1490. Support configurable container placement policy through 'o… #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Double checked all failed UT. Two failure reasons,
@xiaoyuyao Do you have a moment to review this latest 04.patch? |
Contributor
|
bq. Cannot mock/spy class org.apache.hadoop.ozone.om.OzoneManager I think this is related to the change in the pom.xml we only add the topology related xml files to testResources explicitly, but the mokito-extensions from the test/resources is missing, which is need to surpress the warning above. I believe if we add the following to the pom should fix the issue above. Also, please fix the checkstyle issue in the next commit. |
Contributor
Author
|
@xiaoyuyao, thanks for the information. I didn't releasize that it's because I explicitely added the testResouces to the pom.xml, then the resources under ${basedir}/src/test/resources get ignored. I will upload a new commit shortly. |
…zone.scm.container.placement.classname'
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Failed unit tests are all native ACL related. Cannot reproduce them locally. |
xiaoyuyao
approved these changes
Jun 6, 2019
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
+1, I will merge it shortly.
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
… active container failover This PR makes the following changes: * Adds a map called standbyContainerConstraints which stores standby constraints for each container in the job model. The logic for populating the map using the job model is added as Util class. * Adds a check before runStreamProcessor, where the standbyContainerConstraints is checked before launching, if the check succeeds container is launched. If standbyTasks are not enabled in config, existing behaviour is retained. * Adds logic to handle standbyContainerConstraints check failures, which entails releasing the resource, and making an any-host request for the container. * Adds logic in SamzaResourceRequest to order container request such that active-containers take precedence over standby, otherwise based on request-timestamp. * Adds logic in HostAwareContainerAllocator to trap resourceRequests issued by the CPM and the HACA, and a. if it is an any-host for an active container, translate it for a stop a standby. b. if it is for a standby stopped by us, translate it for a resource request for active on standby-host and standby on anyhost. c. in all other cases, proceeds asis. * Adds metrics to capture FailedStandbyAllocations (due to standby constraints), successful standby allocations, number of failovers of active to a valid standby, number of failovers of active to anyhost, in case no standby was found, and number of standby-container-stops completed. Tested on dev setup, a VPC, and a test cluster. Author: Ray Matharu <[email protected]> Author: rmatharu <[email protected]> Reviewers: Jagadish Venkatraman <[email protected]> Closes apache#903 from rmatharu/test-basicStandbyFailover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zone.scm.container.placement.classname'