-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11921. [Addendum] Use consistent hadoop.protobuf.version for protoc #8192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
aajisaka
approved these changes
Jan 19, 2026
Member
aajisaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks!
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Jan 19, 2026
Member
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11921. [Addendum] Use consistent hadoop.protobuf.version for protoc
In PR #8156 (YARN-11921), the hadoop-yarn-csi/pom.xml defines
protoc.version=3.17.3explicitly for the protobuf-maven-plugin.However, the Hadoop trunk project has upgraded to
hadoop.protobuf.version=3.25.5globally (via HADOOP-19605 and related changes), which is the current recommended protobuf version for better security (fixes CVE-2024-7254 etc.) and compatibility.This follow-up PR removes the hardcoded
protoc.version=3.17.3and switches to${hadoop.protobuf.version}to:How was this patch tested?
Verified locally: build succeeds with protobuf sources generated correctly using 3.25.5.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html