-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19472: [ABFS] Remove write aggressiveness optimization #8141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
============================================================
|
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not a part of change here but since we are doing code cleanup here, I feel we should keep these constants in some constant file only like InternalConstants or MetricsConstants.
This file mainly contains constants used in configuration.
Starting from ZERO to SCALE_DIRECTION_NO_ACTION_NEEDED
| * Number of bytes in a gigabyte. | ||
| */ | ||
| public static final long BYTES_PER_GIGABYTE = 1024L * 1024 * 1024; | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few constants in AbfsHttpConstants file that also need to be removed.
| @@ -1,107 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sine there is only one resource utilization metric left. Do we need the base class?
Can we simply have one stand alone class called ResourceUtilizationMetrics instead of saying read/write?
Also anyway we are monitoring JVM resources here, so single metric is sufficient IMO.
Removing write aggressiveness code and related metrics from trunk