-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-17540 Backport ModuleUtil fix #8139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
friscoMad
wants to merge
1
commit into
apache:branch-3.4
Choose a base branch
from
friscoMad:patch-1
base: branch-3.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file breaks using jaxb in the same classpath where Hadoop is present if JVM 9+ See ticket: https://issues.apache.org/jira/browse/HADOOP-17540 This was fixed on apache#7019 for trunk, but the 3.4 branch still has the problem.
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This file breaks using jaxb in the same classpath where Hadoop is present if JVM 9+ See ticket: https://issues.apache.org/jira/browse/HADOOP-17540
This was fixed on #7019 for trunk, but the 3.4 branch still has the problem, I am not sure if you are planning to cut a new release from 3.4 but as I see that there has been commits in that branch I assume that it will happen eventually.
In fact, we would love a 3.3 backport, as I am not sure if Spark 3 will work with Hadoop 3.4 which is our setup.
How was this patch tested?
I have not tested it as I don't have the setup for this project done.
But it should be as simple as generating the shaded jars, expanding, and confirming that the file is not there anymore.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?