Skip to content

HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected. #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuengineer merged 4 commits into from
May 20, 2019
Merged

HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not lock protected. #799

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f5afef
HDDS-1451 : SCMBlockManager findPipeline and createPipeline are not l…
May 7, 2019
f08d3e6
Merge remote-tracking branch 'upstream/trunk' into HDDS-1451-trunk
May 17, 2019
f1b8a32
HDDS-1451 : Address review comments.
May 17, 2019
3ec62af
Merge remote-tracking branch 'upstream/trunk' into HDDS-1451-trunk
May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,18 +182,27 @@ public AllocatedBlock allocateBlock(final long size, ReplicationType type,
pipelineManager
.getPipelines(type, factor, Pipeline.PipelineState.OPEN,
excludeList.getDatanodes(), excludeList.getPipelineIds());
Pipeline pipeline;
Pipeline pipeline = null;
if (availablePipelines.size() == 0) {
try {
// TODO: #CLUTIL Remove creation logic when all replication types and
// factors are handled by pipeline creator
pipeline = pipelineManager.createPipeline(type, factor);
} catch (IOException e) {
LOG.error("Pipeline creation failed for type:{} factor:{}",
type, factor, e);
break;
LOG.warn("Pipeline creation failed for type:{} factor:{}. Retrying " +
"get pipelines call once.", type, factor, e);
availablePipelines = pipelineManager
.getPipelines(type, factor, Pipeline.PipelineState.OPEN,
excludeList.getDatanodes(), excludeList.getPipelineIds());
if (availablePipelines.size() == 0) {
LOG.info("Could not find available pipeline of type:{} and " +
"factor:{} even after retrying", type, factor);
break;
}
}
} else {
}

if (null == pipeline) {
// TODO: #CLUTIL Make the selection policy driven.
pipeline = availablePipelines
.get((int) (Math.random() * availablePipelines.size()));
Expand Down