Skip to content

HADOOP-19674. [JDK 17] Add jaxb-runtime #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brumi1024 merged 5 commits into from
Sep 9, 2025
Merged

HADOOP-19674. [JDK 17] Add jaxb-runtime #7928

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
450d122
HADOOP-19674. [JDK 17] Add jaxb-runtime
K0K0V0K Sep 4, 2025
0b9139b
HADOOP-19674. [JDK 17] Add jaxb-runtime
K0K0V0K Sep 5, 2025
c5a26a7
HADOOP-19674. [JDK 17] Add jaxb-runtime
K0K0V0K Sep 5, 2025
7d1831a
HADOOP-19674. [JDK 17] Add jaxb-runtime
K0K0V0K Sep 6, 2025
56b01d2
HADOOP-19674. [JDK 17] Add jaxb-runtime
K0K0V0K Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions LICENSE-binary
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ Eclipse Distribution License (EDL) 1.0
--------------------------

jakarta.xml.bind:jakarta.xml.bind-api:2.3.3
org.glassfish.jaxb:jaxb-runtime:2.3.9

Eclipse Public License 1.0
--------------------------
Expand Down
4 changes: 4 additions & 0 deletions hadoop-client-modules/hadoop-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
</exclusion>
<exclusion>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
</exclusion>
Copy link
Contributor Author

@K0K0V0K K0K0V0K Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is necessary otherwise at the end on install i am facing this error:

[INFO] Total time:  05:20 min (Wall Clock)
[INFO] Finished at: 2025-09-05T09:02:10+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce-banned-dependencies) on project hadoop-client-check-test-invariants: 
[ERROR] Rule 1: org.apache.maven.plugins.enforcer.BanDuplicateClasses failed with message:
[ERROR] Duplicate classes found:
[ERROR] 
[ERROR]   Found in:
[ERROR]     org.apache.hadoop:hadoop-client-minicluster:jar:3.5.0-SNAPSHOT:compile
[ERROR]     org.apache.hadoop:hadoop-client-runtime:jar:3.5.0-SNAPSHOT:compile
[ERROR]   Duplicate classes:
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/registries/MimeTypeEntry.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/localization/LocalizableMessageFactory$ResourceBundleSupplier.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/registries/MailcapTokenizer.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/FinalArrayList.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/Pool$Impl.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/registries/MailcapParseException.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/registries/LogSupport.class
[ERROR]     META-INF/versions/9/com/sun/istack/logging/StackHelper.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/NotNull.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/XMLStreamException2.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/viewers/TextEditor.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/XMLStreamReaderToContentHandler$1.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/localization/Localizable.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/viewers/ImageViewerCanvas.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/viewers/TextViewer.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/Interned.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/localization/Localizer.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/localization/LocalizableMessageFactory.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/registries/MailcapFile.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/logging/Logger.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/ByteArrayDataSource.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/Nullable.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/localization/NullLocalizable.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/SAXException2.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/registries/MimeTypeFile.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/logging/StackHelper.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/registries/LineTokenizer.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/Builder.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/FragmentContentHandler.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/Pool.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/localization/LocalizableMessage.class
[ERROR]     org/apache/hadoop/shaded/com/sun/activation/viewers/ImageViewer.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/SAXParseException2.class
[ERROR]     org/apache/hadoop/shaded/com/sun/istack/XMLStreamReaderToContentHandler.class

Copy link
Contributor

@stoty stoty Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked 3.4.2, and these classes are not present there.
Based on that, it seems that hadoop-client-runtime indeed does not include jaxb-impl traditionally.

<exclusion>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-util</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions hadoop-common-project/hadoop-common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,11 @@
<artifactId>junit-platform-launcher</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<scope>runtime</scope>
</dependency>
</dependencies>

<build>
Expand Down
5 changes: 5 additions & 0 deletions hadoop-common-project/hadoop-kms/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-webapp</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-webapp</artifactId>
Expand Down
8 changes: 8 additions & 0 deletions hadoop-project/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@
<!-- jersey version -->
<jersey2.version>2.46</jersey2.version>

<!-- jaxb version -->
<jaxb.version>2.3.9</jaxb.version>

<!-- jackson versions -->
<jackson2.version>2.14.3</jackson2.version>
<jackson2.databind.version>2.14.3</jackson2.databind.version>
Expand Down Expand Up @@ -2152,6 +2155,11 @@
<artifactId>jersey-media-json-jettison</artifactId>
<version>${jersey2.version}</version>
</dependency>
<dependency>
Copy link
Contributor

@stoty stoty Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're globally dependency managing jaxb-runtime, I think that we don't need all the excludes in this patch.
They should all be dependency managed to 2.3.9 by maven, and the dependency convergence check should pass.

Copy link
Contributor

@stoty stoty Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the reported error was for the earlier patch without the global dependency management.

<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<version>${jaxb.version}</version>
</dependency>
<dependency>
<groupId>net.jodah</groupId>
<artifactId>failsafe</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions ...adoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,11 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-util</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@
<dependency>
<groupId>org.ehcache</groupId>
<artifactId>ehcache</artifactId>
<exclusions>
<exclusion>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.github.ben-manes.caffeine</groupId>
Expand Down
5 changes: 5 additions & 0 deletions hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
</dependency>
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down